Define strerror() for Windows #1834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkindahl
requested review from
pmwkaa and
WireBaron
and removed request for
a team
mkindahl
force-pushed
the
fix_pg_strerror
branch
from
22b5432
to
44f64d7
Compare
erimatnor
approved these changes
Apr 20, 2020
| #endif | ||
| } | ||
|
|
||
| /* We cannot define `pg_strerror` here because there is a #define in PG12 that |
There was a problem hiding this comment.
The markdown formatting seems unnecessary in C comments
There was a problem hiding this comment.
I use this to avoid confusion when mixing English text with references to symbols in the code.
| @@ -25,6 +27,24 @@ set_error(int err) | |||
| #endif | |||
| } | |||
|
|
|||
| static int | |||
| get_error(void) | |||
There was a problem hiding this comment.
Suggested change
| get_error(void) | |
| get_socket_error(void) |
Given that this is, at least on Windows, only used for Winsock-related errors.
There was a problem hiding this comment.
IMHO, the function itself is not restricted to socket-related errors, it is generic, and there is a corresponding function set_error above this one, so it makes sense to stick to the conventions already established by this.
mkindahl
force-pushed
the
fix_pg_strerror
branch
2 times, most recently
from
22cf766
to
7648c3f
Compare
pmwkaa
approved these changes
Apr 20, 2020
The symbol `pgwin32_socket_strerror` was undefined on windows builds at PG12 and later. This because the function was removed and instead `pg_strerror` was introduced to be used on all platforms. This commit fixes the issue by ensuring to use `pg_strerror` on PG12 and later, and `pgwin32_socket_strerror` on Windows builds before PG12. Found using `clang-tidy`
mkindahl
force-pushed
the
fix_pg_strerror
branch
from
7648c3f
to
81d9b71
Compare
Codecov Report
@@ Coverage Diff @@
## master #1834 +/- ##
==========================================
- Coverage 89.72% 89.60% -0.12%
==========================================
Files 150 144 -6
Lines 22696 22118 -578
==========================================
- Hits 20364 19819 -545
+ Misses 2332 2299 -33
Continue to review full report at Codecov.
|
svenklemm
added a commit
to svenklemm/timescaledb
that referenced
this pull request
May 15, 2020
This maintenance release contains bugfixes since the 1.7.0 release. We deem it medium priority for upgrading. In particular the fixes contained in this maintenance release address bugs in continuous aggregates with real-time aggregation and PostgreSQL 12 support. **Bugfixes** * timescale#1834 Define strerror() for Windows * timescale#1846 Fix segfault on COPY to hypertable * timescale#1850 Fix scheduler failure due to bad next_start_time for jobs * timescale#1851 Fix hypertable expansion for UNION ALL * timescale#1861 Fix qual pushodwn for compressed hypertables where quals have casts * timescale#1868 Add support for WHERE, HAVING clauses with real time aggregates * timescale#1871 Don't rely on timescaledb.restoring for upgrade * timescale#1875 Fix hypertable detection in subqueries **Thanks** * @frostwind for reporting issue with casts in where clauses on compressed hypertables * @fvannee for reporting an issue with hypertable detection in inlined SQL functions and an issue with COPY * @hgiasac for reporting missing where clause with real time aggregates * @dhodyn for reporting an issue with UNION ALL queries * @pehlert for reporting an issue with pg_upgrade * @Olernov for reporting and fixing an issue with compressed chunks in the reorder policy
svenklemm
added a commit
to svenklemm/timescaledb
that referenced
this pull request
May 15, 2020
This maintenance release contains bugfixes since the 1.7.0 release. We deem it medium priority for upgrading. In particular the fixes contained in this maintenance release address bugs in continuous aggregates with real-time aggregation and PostgreSQL 12 support. **Bugfixes** * timescale#1834 Define strerror() for Windows * timescale#1846 Fix segfault on COPY to hypertable * timescale#1850 Fix scheduler failure due to bad next_start_time for jobs * timescale#1851 Fix hypertable expansion for UNION ALL * timescale#1861 Fix qual pushodwn for compressed hypertables where quals have casts * timescale#1868 Add support for WHERE, HAVING clauses with real time aggregates * timescale#1871 Don't rely on timescaledb.restoring for upgrade * timescale#1875 Fix hypertable detection in subqueries **Thanks** * @frostwind for reporting issue with casts in where clauses on compressed hypertables * @fvannee for reporting an issue with hypertable detection in inlined SQL functions and an issue with COPY * @hgiasac for reporting missing where clause with real time aggregates * @dhodyn for reporting an issue with UNION ALL queries * @pehlert for reporting an issue with pg_upgrade * @Olernov for reporting and fixing an issue with compressed chunks in the reorder policy
svenklemm
added a commit
to svenklemm/timescaledb
that referenced
this pull request
May 15, 2020
This maintenance release contains bugfixes since the 1.7.0 release. We deem it medium priority for upgrading. In particular the fixes contained in this maintenance release address bugs in continuous aggregates with real-time aggregation and PostgreSQL 12 support. **Bugfixes** * timescale#1834 Define strerror() for Windows * timescale#1846 Fix segfault on COPY to hypertable * timescale#1850 Fix scheduler failure due to bad next_start_time for jobs * timescale#1851 Fix hypertable expansion for UNION ALL * timescale#1861 Fix qual pushdown for compressed hypertables where quals have casts * timescale#1864 Fix issue with subplan selection in parallel ChunkAppend * timescale#1868 Add support for WHERE, HAVING clauses with real time aggregates * timescale#1871 Don't rely on timescaledb.restoring for upgrade * timescale#1875 Fix hypertable detection in subqueries **Thanks** * @frostwind for reporting issue with casts in where clauses on compressed hypertables * @fvannee for reporting an issue with hypertable detection in inlined SQL functions and an issue with COPY * @hgiasac for reporting missing where clause with real time aggregates * @airton-neto for reporting an issue with queries over UNIONs of hypertables * @dhodyn for reporting an issue with UNION ALL queries * @pehlert for reporting an issue with pg_upgrade * @Olernov for reporting and fixing an issue with compressed chunks in the reorder policy
Merged
svenklemm
added a commit
to svenklemm/timescaledb
that referenced
this pull request
May 15, 2020
This maintenance release contains bugfixes since the 1.7.0 release. We deem it medium priority for upgrading. In particular the fixes contained in this maintenance release address bugs in continuous aggregates with real-time aggregation and PostgreSQL 12 support. **Bugfixes** * timescale#1834 Define strerror() for Windows * timescale#1846 Fix segfault on COPY to hypertable * timescale#1850 Fix scheduler failure due to bad next_start_time for jobs * timescale#1851 Fix hypertable expansion for UNION ALL * timescale#1861 Fix qual pushdown for compressed hypertables where quals have casts * timescale#1864 Fix issue with subplan selection in parallel ChunkAppend * timescale#1868 Add support for WHERE, HAVING clauses with real time aggregates * timescale#1871 Don't rely on timescaledb.restoring for upgrade * timescale#1875 Fix hypertable detection in subqueries * timescale#1884 Fix crash on SELECT WHERE NOT with empty table **Thanks** * @frostwind for reporting issue with casts in where clauses on compressed hypertables * @fvannee for reporting an issue with hypertable detection in inlined SQL functions and an issue with COPY * @hgiasac for reporting missing where clause with real time aggregates * @airton-neto for reporting an issue with queries over UNIONs of hypertables * @dhodyn for reporting an issue with UNION ALL queries * @pehlert for reporting an issue with pg_upgrade * @Olernov for reporting and fixing an issue with compressed chunks in the reorder policy * @michael-sayapin for reporting an issue with INSERTs and WHERE NOT EXISTS
svenklemm
added a commit
to svenklemm/timescaledb
that referenced
this pull request
May 15, 2020
This maintenance release contains bugfixes since the 1.7.0 release. We deem it medium priority for upgrading. In particular the fixes contained in this maintenance release address bugs in continuous aggregates with real-time aggregation and PostgreSQL 12 support. **Bugfixes** * timescale#1834 Define strerror() for Windows * timescale#1846 Fix segfault on COPY to hypertable * timescale#1850 Fix scheduler failure due to bad next_start_time for jobs * timescale#1851 Fix hypertable expansion for UNION ALL * timescale#1854 Fix reorder policy job to skip compressed chunks * timescale#1861 Fix qual pushdown for compressed hypertables where quals have casts * timescale#1864 Fix issue with subplan selection in parallel ChunkAppend * timescale#1868 Add support for WHERE, HAVING clauses with real time aggregates * timescale#1871 Don't rely on timescaledb.restoring for upgrade * timescale#1875 Fix hypertable detection in subqueries * timescale#1884 Fix crash on SELECT WHERE NOT with empty table **Thanks** * @frostwind for reporting an issue with casts in where clauses on compressed hypertables * @fvannee for reporting an issue with hypertable detection in inlined SQL functions and an issue with COPY * @hgiasac for reporting missing where clause with real time aggregates * @airton-neto for reporting an issue with queries over UNIONs of hypertables * @dhodyn for reporting an issue with UNION ALL queries * @pehlert for reporting an issue with pg_upgrade * @Olernov for reporting and fixing an issue with compressed chunks in the reorder policy * @michael-sayapin for reporting an issue with INSERTs and WHERE NOT EXISTS
svenklemm
added a commit
to svenklemm/timescaledb
that referenced
this pull request
May 15, 2020
This maintenance release contains bugfixes since the 1.7.0 release. We deem it medium priority for upgrading. In particular the fixes contained in this maintenance release address bugs in continuous aggregates with real-time aggregation and PostgreSQL 12 support. **Bugfixes** * timescale#1834 Define strerror() for Windows * timescale#1846 Fix segfault on COPY to hypertable * timescale#1850 Fix scheduler failure due to bad next_start_time for jobs * timescale#1851 Fix hypertable expansion for UNION ALL * timescale#1854 Fix reorder policy job to skip compressed chunks * timescale#1861 Fix qual pushdown for compressed hypertables where quals have casts * timescale#1864 Fix issue with subplan selection in parallel ChunkAppend * timescale#1868 Add support for WHERE, HAVING clauses with real time aggregates * timescale#1871 Don't rely on timescaledb.restoring for upgrade * timescale#1875 Fix hypertable detection in subqueries * timescale#1884 Fix crash on SELECT WHERE NOT with empty table **Thanks** * @frostwind for reporting an issue with casts in where clauses on compressed hypertables * @fvannee for reporting an issue with hypertable detection in inlined SQL functions and an issue with COPY * @hgiasac for reporting missing where clause with real time aggregates * @airton-neto for reporting an issue with queries over UNIONs of hypertables * @dhodyn for reporting an issue with UNION ALL queries * @pehlert for reporting an issue with pg_upgrade * @Olernov for reporting and fixing an issue with compressed chunks in the reorder policy * @michael-sayapin for reporting an issue with INSERTs and WHERE NOT EXISTS
svenklemm
added a commit
to svenklemm/timescaledb
that referenced
this pull request
May 15, 2020
This maintenance release contains bugfixes since the 1.7.0 release. We deem it medium priority for upgrading and high priority for users with multiple continuous aggregates. In particular the fixes contained in this maintenance release address bugs in continuous aggregates with real-time aggregation and PostgreSQL 12 support. **Bugfixes** * timescale#1834 Define strerror() for Windows * timescale#1846 Fix segfault on COPY to hypertable * timescale#1850 Fix scheduler failure due to bad next_start_time for jobs * timescale#1851 Fix hypertable expansion for UNION ALL * timescale#1854 Fix reorder policy job to skip compressed chunks * timescale#1861 Fix qual pushdown for compressed hypertables where quals have casts * timescale#1864 Fix issue with subplan selection in parallel ChunkAppend * timescale#1868 Add support for WHERE, HAVING clauses with real time aggregates * timescale#1869 Fix real time aggregate support for multiple continuous aggregates * timescale#1871 Don't rely on timescaledb.restoring for upgrade * timescale#1875 Fix hypertable detection in subqueries * timescale#1884 Fix crash on SELECT WHERE NOT with empty table **Thanks** * @airton-neto for reporting an issue with queries over UNIONs of hypertables * @dhodyn for reporting an issue with UNION ALL queries * @frostwind for reporting an issue with casts in where clauses on compressed hypertables * @fvannee for reporting an issue with hypertable detection in inlined SQL functions and an issue with COPY * @hgiasac for reporting missing where clause with real time aggregates * @louisth for reporting an issue with real-time aggregation and multiple continuous aggregates * @michael-sayapin for reporting an issue with INSERTs and WHERE NOT EXISTS * @Olernov for reporting and fixing an issue with compressed chunks in the reorder policy * @pehlert for reporting an issue with pg_upgrade
svenklemm
added a commit
to svenklemm/timescaledb
that referenced
this pull request
May 17, 2020
This maintenance release contains bugfixes since the 1.7.0 release. We deem it medium priority for upgrading and high priority for users with multiple continuous aggregates. In particular the fixes contained in this maintenance release address bugs in continuous aggregates with real-time aggregation and PostgreSQL 12 support. **Bugfixes** * timescale#1834 Define strerror() for Windows * timescale#1846 Fix segfault on COPY to hypertable * timescale#1850 Fix scheduler failure due to bad next_start_time for jobs * timescale#1851 Fix hypertable expansion for UNION ALL * timescale#1854 Fix reorder policy job to skip compressed chunks * timescale#1861 Fix qual pushdown for compressed hypertables where quals have casts * timescale#1864 Fix issue with subplan selection in parallel ChunkAppend * timescale#1868 Add support for WHERE, HAVING clauses with real time aggregates * timescale#1869 Fix real time aggregate support for multiple continuous aggregates * timescale#1871 Don't rely on timescaledb.restoring for upgrade * timescale#1875 Fix hypertable detection in subqueries * timescale#1884 Fix crash on SELECT WHERE NOT with empty table **Thanks** * @airton-neto for reporting an issue with queries over UNIONs of hypertables * @dhodyn for reporting an issue with UNION ALL queries * @frostwind for reporting an issue with casts in where clauses on compressed hypertables * @fvannee for reporting an issue with hypertable detection in inlined SQL functions and an issue with COPY * @hgiasac for reporting missing where clause with real time aggregates * @louisth for reporting an issue with real-time aggregation and multiple continuous aggregates * @michael-sayapin for reporting an issue with INSERTs and WHERE NOT EXISTS * @Olernov for reporting and fixing an issue with compressed chunks in the reorder policy * @pehlert for reporting an issue with pg_upgrade
svenklemm
added a commit
to svenklemm/timescaledb
that referenced
this pull request
May 18, 2020
This maintenance release contains bugfixes since the 1.7.0 release. We deem it medium priority for upgrading and high priority for users with multiple continuous aggregates. In particular the fixes contained in this maintenance release address bugs in continuous aggregates with real-time aggregation and PostgreSQL 12 support. **Bugfixes** * timescale#1834 Define strerror() for Windows * timescale#1846 Fix segfault on COPY to hypertable * timescale#1850 Fix scheduler failure due to bad next_start_time for jobs * timescale#1851 Fix hypertable expansion for UNION ALL * timescale#1854 Fix reorder policy job to skip compressed chunks * timescale#1861 Fix qual pushdown for compressed hypertables where quals have casts * timescale#1864 Fix issue with subplan selection in parallel ChunkAppend * timescale#1868 Add support for WHERE, HAVING clauses with real time aggregates * timescale#1869 Fix real time aggregate support for multiple continuous aggregates * timescale#1871 Don't rely on timescaledb.restoring for upgrade * timescale#1875 Fix hypertable detection in subqueries * timescale#1884 Fix crash on SELECT WHERE NOT with empty table **Thanks** * @airton-neto for reporting an issue with queries over UNIONs of hypertables * @dhodyn for reporting an issue with UNION ALL queries * @frostwind for reporting an issue with casts in where clauses on compressed hypertables * @fvannee for reporting an issue with hypertable detection in inlined SQL functions and an issue with COPY * @hgiasac for reporting missing where clause with real time aggregates * @louisth for reporting an issue with real-time aggregation and multiple continuous aggregates * @michael-sayapin for reporting an issue with INSERTs and WHERE NOT EXISTS * @Olernov for reporting and fixing an issue with compressed chunks in the reorder policy * @pehlert for reporting an issue with pg_upgrade
svenklemm
added a commit
that referenced
this pull request
May 18, 2020
This maintenance release contains bugfixes since the 1.7.0 release. We deem it medium priority for upgrading and high priority for users with multiple continuous aggregates. In particular the fixes contained in this maintenance release address bugs in continuous aggregates with real-time aggregation and PostgreSQL 12 support. **Bugfixes** * #1834 Define strerror() for Windows * #1846 Fix segfault on COPY to hypertable * #1850 Fix scheduler failure due to bad next_start_time for jobs * #1851 Fix hypertable expansion for UNION ALL * #1854 Fix reorder policy job to skip compressed chunks * #1861 Fix qual pushdown for compressed hypertables where quals have casts * #1864 Fix issue with subplan selection in parallel ChunkAppend * #1868 Add support for WHERE, HAVING clauses with real time aggregates * #1869 Fix real time aggregate support for multiple continuous aggregates * #1871 Don't rely on timescaledb.restoring for upgrade * #1875 Fix hypertable detection in subqueries * #1884 Fix crash on SELECT WHERE NOT with empty table **Thanks** * @airton-neto for reporting an issue with queries over UNIONs of hypertables * @dhodyn for reporting an issue with UNION ALL queries * @frostwind for reporting an issue with casts in where clauses on compressed hypertables * @fvannee for reporting an issue with hypertable detection in inlined SQL functions and an issue with COPY * @hgiasac for reporting missing where clause with real time aggregates * @louisth for reporting an issue with real-time aggregation and multiple continuous aggregates * @michael-sayapin for reporting an issue with INSERTs and WHERE NOT EXISTS * @Olernov for reporting and fixing an issue with compressed chunks in the reorder policy * @pehlert for reporting an issue with pg_upgrade
svenklemm
added a commit
that referenced
this pull request
May 18, 2020
This maintenance release contains bugfixes since the 1.7.0 release. We deem it medium priority for upgrading and high priority for users with multiple continuous aggregates. In particular the fixes contained in this maintenance release address bugs in continuous aggregates with real-time aggregation and PostgreSQL 12 support. **Bugfixes** * #1834 Define strerror() for Windows * #1846 Fix segfault on COPY to hypertable * #1850 Fix scheduler failure due to bad next_start_time for jobs * #1851 Fix hypertable expansion for UNION ALL * #1854 Fix reorder policy job to skip compressed chunks * #1861 Fix qual pushdown for compressed hypertables where quals have casts * #1864 Fix issue with subplan selection in parallel ChunkAppend * #1868 Add support for WHERE, HAVING clauses with real time aggregates * #1869 Fix real time aggregate support for multiple continuous aggregates * #1871 Don't rely on timescaledb.restoring for upgrade * #1875 Fix hypertable detection in subqueries * #1884 Fix crash on SELECT WHERE NOT with empty table **Thanks** * @airton-neto for reporting an issue with queries over UNIONs of hypertables * @dhodyn for reporting an issue with UNION ALL queries * @frostwind for reporting an issue with casts in where clauses on compressed hypertables * @fvannee for reporting an issue with hypertable detection in inlined SQL functions and an issue with COPY * @hgiasac for reporting missing where clause with real time aggregates * @louisth for reporting an issue with real-time aggregation and multiple continuous aggregates * @michael-sayapin for reporting an issue with INSERTs and WHERE NOT EXISTS * @Olernov for reporting and fixing an issue with compressed chunks in the reorder policy * @pehlert for reporting an issue with pg_upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The symbol
pgwin32_socket_strerrorwas undefined on windows builds atPG12 and later. This because the function was removed and instead
pg_strerrorwas introduced to be used on all platforms.This commit fixes the issue by ensuring to use
pg_strerroron PG12and later, and
pgwin32_socket_strerroron Windows builds before PG12.