Remove tuple lock on select path #2336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When executing a SELECT on a hypertable, it is not possible to acquire tuple locks on hot standbys since they require a transaction id and transaction ids cannot be created when running as a standby running in ephemeral recovery mode. This commit removes the tuple lock from the SELECT code path if running in recovery mode.
mkindahl
force-pushed
the
remove_select_tuple_lock
branch
from
9b38903
to
35381b2
Compare
svenklemm
approved these changes
Sep 7, 2020
|
dont forget to do similar PR against master |
svenklemm
added a commit
to svenklemm/timescaledb
that referenced
this pull request
Sep 7, 2020
This maintenance release contains bugfixes since the 1.7.3 release. We deem it high priority for upgrading. In particular the fixes contained in this maintenance release address an issue with running queries on compressed hypertables on standby nodes. **Bugfixes** * timescale#2336 Remove tuple lock on select path
Merged
svenklemm
added a commit
that referenced
this pull request
Sep 7, 2020
This maintenance release contains bugfixes since the 1.7.3 release. We deem it high priority for upgrading. In particular the fixes contained in this maintenance release address an issue with running queries on compressed hypertables on standby nodes. **Bugfixes** * #2336 Remove tuple lock on select path
svenklemm
added a commit
that referenced
this pull request
Sep 7, 2020
This maintenance release contains bugfixes since the 1.7.3 release. We deem it high priority for upgrading. In particular the fixes contained in this maintenance release address an issue with running queries on compressed hypertables on standby nodes. **Bugfixes** * #2336 Remove tuple lock on select path
svenklemm
added a commit
that referenced
this pull request
Sep 7, 2020
This maintenance release contains bugfixes since the 1.7.3 release. We deem it high priority for upgrading if TimescaleDB is deployed with replicas (synchronous or asynchronous). In particular the fixes contained in this maintenance release address an issue with running queries on compressed hypertables on standby nodes. **Bugfixes** * #2336 Remove tuple lock on select path
svenklemm
added a commit
to svenklemm/timescaledb
that referenced
this pull request
Sep 7, 2020
This maintenance release contains bugfixes since the 1.7.3 release. We deem it high priority for upgrading. In particular the fixes contained in this maintenance release address an issue with running queries on compressed hypertables on standby nodes. **Bugfixes** * timescale#2336 Remove tuple lock on select path
svenklemm
added a commit
to svenklemm/timescaledb
that referenced
this pull request
Sep 7, 2020
This maintenance release contains bugfixes since the 1.7.3 release. We deem it high priority for upgrading if TimescaleDB is deployed with replicas (synchronous or asynchronous). In particular the fixes contained in this maintenance release address an issue with running queries on compressed hypertables on standby nodes. **Bugfixes** * timescale#2336 Remove tuple lock on select path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When executing a SELECT on a hypertable, it is not possible to acquire
tuple locks since they require a transaction id and transaction ids
cannot be created when running as a standby running in ephemeral
recovery mode.
This commit removes the tuple lock from the SELECT code path. Since
this means that a slice might not be found as a result of a scan, we
need to ignore that dimension slice to avoid a segmentation fault.