Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename policy parameters #2458

Merged
merged 1 commit into from Sep 29, 2020
Merged

Conversation

erimatnor
Copy link
Contributor

@erimatnor erimatnor commented Sep 28, 2020

Policy parameters are renamed to be more consistent and intuitive
across different policies.

Fixes #2442

@erimatnor erimatnor added this to the 2.0.0 milestone Sep 28, 2020
@erimatnor
Copy link
Contributor Author

Note that reorder policy has no parameter for delayed reordering, so there was no parameter to rename to reorder_after as suggestion in issue #2442

@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #2458 into master will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2458      +/-   ##
==========================================
+ Coverage   89.99%   90.10%   +0.11%     
==========================================
  Files         213      213              
  Lines       34406    34356      -50     
==========================================
- Hits        30964    30958       -6     
+ Misses       3442     3398      -44     
Impacted Files Coverage Δ
src/copy.c 87.86% <ø> (-0.20%) ⬇️
src/indexing.c 94.87% <ø> (ø)
src/planner.c 93.80% <ø> (ø)
tsl/src/remote/dist_ddl.c 98.66% <ø> (ø)
src/cache_invalidate.c 84.44% <100.00%> (+0.72%) ⬆️
src/loader/bgw_launcher.c 89.53% <100.00%> (ø)
src/process_utility.c 93.70% <100.00%> (+<0.01%) ⬆️
tsl/src/fdw/shippable.c 82.85% <0.00%> (-11.43%) ⬇️
src/loader/bgw_message_queue.c 87.09% <0.00%> (ø)
src/import/planner.c 69.54% <0.00%> (+10.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 882a247...354acf0. Read the comment docs.

@erimatnor erimatnor marked this pull request as ready for review September 28, 2020 14:24
@erimatnor erimatnor requested a review from a team as a code owner September 28, 2020 14:24
@erimatnor erimatnor requested review from mkindahl, WireBaron, svenklemm, k-rus and pmwkaa and removed request for a team September 28, 2020 14:24
Copy link
Contributor

@pmwkaa pmwkaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need any renames in the corresponding C functions as well?

Policy parameters are renamed to be more consistent and intuitive
across different policies.

Fixes timescale#2442
@erimatnor erimatnor changed the title Rename policy parameter names Rename policy parameters Sep 29, 2020
@erimatnor erimatnor merged commit d11256b into timescale:master Sep 29, 2020
@erimatnor erimatnor deleted the rename-policy-params branch September 29, 2020 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename arguments of add policy functions
3 participants