Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash and cancel when adding data node #2751

Merged
merged 1 commit into from Dec 17, 2020
Merged

Fix crash and cancel when adding data node #2751

merged 1 commit into from Dec 17, 2020

Commits on Dec 16, 2020

  1. Fix crash and cancel when adding data node 

    This change fixes two issues with `add_data_node`:

1. In one case, a check for a valid connection pointer was not done,
   causing a segmentation fault when connection attempts failed.

2. Connections were made with a blocking API that hangs
   indefinitely when the receiving end is not responding. The user
   couldn't cancel the connection attempt with CTRL-C, since no wait
   latch or interrupt checking was used. The code is now updated to
   use a non-blocking connection API, where it is possible to wait on
   the socket and latch, respecting interrupts.
    @erimatnor
    erimatnor committed Dec 16, 2020
    Copy the full SHA
    8c0d47a View commit details
    Browse the repository at this point in the history