Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test building against PG13 in CI #2832

Merged
merged 5 commits into from Jan 15, 2021
Merged

Conversation

svenklemm
Copy link
Member

No description provided.

@svenklemm svenklemm requested a review from a team as a code owner January 15, 2021 08:32
@svenklemm svenklemm requested review from pmwkaa, k-rus, gayyappan, mkindahl and erimatnor and removed request for a team January 15, 2021 08:32
@svenklemm svenklemm force-pushed the pg13_ci branch 2 times, most recently from e95d628 to f95e68b Compare January 15, 2021 09:03
@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #2832 (46bd221) into master (f61f5a0) will increase coverage by 0.14%.
The diff coverage is 98.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2832      +/-   ##
==========================================
+ Coverage   90.10%   90.24%   +0.14%     
==========================================
  Files         212      212              
  Lines       34670    34670              
==========================================
+ Hits        31240    31289      +49     
+ Misses       3430     3381      -49     
Impacted Files Coverage Δ
src/chunk_append/explain.c 82.81% <ø> (ø)
src/compat.h 100.00% <ø> (ø)
src/copy.c 87.91% <ø> (ø)
src/cross_module_fn.c 68.54% <ø> (ø)
src/jsonb_utils.c 81.70% <ø> (ø)
src/loader/loader.c 92.76% <ø> (ø)
src/planner.c 93.72% <ø> (ø)
tsl/src/fdw/modify_exec.c 83.23% <ø> (ø)
tsl/src/init.c 82.35% <ø> (ø)
tsl/src/remote/async.c 83.14% <ø> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df3359b...46bd221. Read the comment docs.

@svenklemm svenklemm force-pushed the pg13_ci branch 4 times, most recently from 3def75d to a5f94b8 Compare January 15, 2021 10:16
Copy link
Contributor

@mkindahl mkindahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The failing PG11 and PG12 tests looks like flakes, but please make sure that there is nothing else.

@svenklemm svenklemm force-pushed the pg13_ci branch 3 times, most recently from 905a897 to 39db91a Compare January 15, 2021 11:16
PG13 merges setup_append_rel_array into setup_simple_rel_arrays
which we use to build the append_rel_array.

postgres/postgres@1661a40505
PG13 changes the signature of AlterTable so we switch to using
AlterTableInternal instead.
PG13 added a bitmap of EquivalenceClass indexes to RelOptInfo so
any prepend to the list of EquivalenceClasses would invalidate
the BitmapSet.

postgres/postgres@3373c71553
Since the actual tests have not been adjusted for PG13 yet this
only checks compiling against PG13. A subsequent PR will enable
tests for PG13.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants