Fix crash while using REINDEX TABLE CONCURRENTLY #3123

pmwkaa · 2021-04-15T13:30:11Z

Fix crash while using REINDEX TABLE CONCURRENTLY

CONCURRENTLY option of the REINDEX TABLE is not supported and
leads to a crash when using with hypertable. Block it and print
the error message.

Fix #3122

codecov · 2021-04-15T13:44:41Z

Codecov Report

Merging #3123 (cd41ea1) into master (d26c744) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3123      +/-   ##
==========================================
- Coverage   90.33%   90.31%   -0.03%     
==========================================
  Files         215      215              
  Lines       35254    35256       +2     
==========================================
- Hits        31848    31840       -8     
- Misses       3406     3416      +10

Impacted Files	Coverage Δ
src/process_utility.c	`93.85% <100.00%> (+<0.01%)`	⬆️
src/loader/bgw_launcher.c	`89.50% <0.00%> (-2.47%)`	⬇️
tsl/src/reorder.c	`81.84% <0.00%> (-0.27%)`	⬇️
tsl/src/nodes/data_node_dispatch.c	`97.07% <0.00%> (-0.25%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d26c744...cd41ea1. Read the comment docs.

pmwkaa · 2021-04-15T13:58:33Z

Index test on PG11 is failing, working on a template test file

erimatnor · 2021-04-16T08:31:01Z

src/process_utility.c

+				{
+					stmt->concurrent = false;
+					ereport(NOTICE,
+							(errmsg("REINDEX TABLE CONCURRENTLY is unsupported on a hypertable"),


It is unclear why this isn't an error. People can just drop CONCURRENTLY if they want to reindex.

I also suggest formulating similar to this PostgreSQL error: ""concurrent index creation on system catalog tables is not supported":

Suggested change

(errmsg("REINDEX TABLE CONCURRENTLY is unsupported on a hypertable"),

(errmsg("concurrent index creation on hypertables is not supported"),

I am fine to throw an error here, I've seen that PostgreSQL actually also switches to regular implementation in some cases and shows a NOTICE in such cases. I guess we should decide for yourselves

Can you point to the place in the PostgreSQL code where they do this?

It seems odd to me, because if PostgreSQL has implemented CONCURRENTLY I don't understand why they wouldn't use it, unless they do to this bait-and-switch depending on object type.

Sorry, I misunderstood when checked the code for first time, I had a different impression. Switched to produce the error as suggest.

erimatnor · 2021-04-16T08:31:43Z

src/process_utility.c

+					stmt->concurrent = false;
+					ereport(NOTICE,
+							(errmsg("REINDEX TABLE CONCURRENTLY is unsupported on a hypertable"),
+							 errdetail("Using non-concurrent implementation.")));


Again, not sure we need this since we should probably just generate an error above.

Suggested change

errdetail("Using non-concurrent implementation.")));

errdetail("Performing non-concurrent reindexing instead.")));

gayyappan

Question about test MakeList.

test/sql/CMakeLists.txt

svenklemm · 2021-04-17T01:45:59Z

Needs changelog entry.

CONCURRENTLY option of the REINDEX TABLE is not supported and leads to a crash when using with hypertable. Block it and print the error message. Fix timescale#3122

index text was moved into SQL test template in timescale#3123 and generated_columns - in timescale#2927.

`index` test was moved into SQL test template in timescale#3123 and `generated_columns` - in timescale#2927. They are added to relevant gitignore.

`index` test was moved into SQL test template in #3123 and `generated_columns` - in #2927. They are added to relevant gitignore.

@Dead2

This maintenance release contains bugfixes since the 2.1.0 release. We deem it high priority for upgrading. This release adds support for Skip Scan on multinode by enabling the pushdown of `DISTINCT` to data nodes and also fixes a number of bugs in the implementation of Skip Scan. **Features** * timescale#3113 Pushdown "SELECT DISTINCT" in multi-node to allow use of Skip Scan **Bugfixes** * timescale#3101 Use commit date in `get_git_commit()` * timescale#3104 Fix use after free in `add_reorder_policy` * timescale#3106 Fix use after free in `chunk_api_get_chunk_stats` * timescale#3123 Fix crash while using `REINDEX TABLE CONCURRENTLY` * timescale#3135 Fix SkipScan path generation in `DISTINCT` queries with expressions * timescale#3146 Fix SkipScan for IndexPaths without pathkeys * timescale#3151 Fix `fdw_relinfo_get` assertion failure on DELETE * timescale#3155 Inherit CFLAGS from PostgreSQL * timescale#3109 Copy recreated object permissions on update * timescale#3148 Make `SELECT DISTINCT` handle non-var targetlists * timescale#3147 Skip ChunkAppend if AppendPath has no children * timescale#3102 Fix REINDEX TABLE for distributed hypertables * timescale#3118 Fix use after free in cache * timescale#3112 Use `%u` to format Oid instead of `%d` * timescale#3111 Fix `CMAKE_BUILD_TYPE` check **Thanks** * @Dead2, @dv8472 and @einsibjarni for reporting an issue with multinode queries and views * @hperez75 for reporting an issue with Skip Scan

@Dead2

This maintenance release contains bugfixes since the 2.1.0 release. We deem it high priority for upgrading. This release adds support for Skip Scan on multinode by enabling the pushdown of `DISTINCT` to data nodes and also fixes a number of bugs in the implementation of Skip Scan. **Features** * timescale#3113 Pushdown "SELECT DISTINCT" in multi-node to allow use of Skip Scan **Bugfixes** * timescale#3101 Use commit date in `get_git_commit()` * timescale#3104 Fix use after free in `add_reorder_policy` * timescale#3106 Fix use after free in `chunk_api_get_chunk_stats` * timescale#3123 Fix crash while using `REINDEX TABLE CONCURRENTLY` * timescale#3135 Fix SkipScan path generation in `DISTINCT` queries with expressions * timescale#3146 Fix SkipScan for IndexPaths without pathkeys * timescale#3151 Fix `fdw_relinfo_get` assertion failure on DELETE * timescale#3155 Inherit CFLAGS from PostgreSQL * timescale#3109 Copy recreated object permissions on update * timescale#3148 Make `SELECT DISTINCT` handle non-var targetlists * timescale#3147 Skip ChunkAppend if AppendPath has no children * timescale#3102 Fix REINDEX TABLE for distributed hypertables * timescale#3118 Fix use after free in cache * timescale#3112 Use `%u` to format Oid instead of `%d` * timescale#3111 Fix `CMAKE_BUILD_TYPE` check **Thanks** * @Dead2, @dv8472 and @einsibjarni for reporting an issue with multinode queries and views * @hperez75 for reporting an issue with Skip Scan

@Dead2

This maintenance release contains bugfixes since the 2.1.0 release. We deem it high priority for upgrading. This release adds support for Skip Scan on multinode by enabling the pushdown of `DISTINCT` to data nodes and also fixes a number of bugs in the implementation of Skip Scan. **Features** * timescale#3113 Pushdown "SELECT DISTINCT" in multi-node to allow use of Skip Scan **Bugfixes** * timescale#3101 Use commit date in `get_git_commit()` * timescale#3104 Fix use after free in `add_reorder_policy` * timescale#3106 Fix use after free in `chunk_api_get_chunk_stats` * timescale#3123 Fix crash while using `REINDEX TABLE CONCURRENTLY` * timescale#3135 Fix SkipScan path generation in `DISTINCT` queries with expressions * timescale#3146 Fix SkipScan for IndexPaths without pathkeys * timescale#3151 Fix `fdw_relinfo_get` assertion failure on DELETE * timescale#3155 Inherit CFLAGS from PostgreSQL * timescale#3109 Copy recreated object permissions on update * timescale#3148 Make `SELECT DISTINCT` handle non-var targetlists * timescale#3147 Skip ChunkAppend if AppendPath has no children * timescale#3102 Fix REINDEX TABLE for distributed hypertables * timescale#3118 Fix use after free in cache * timescale#3112 Use `%u` to format Oid instead of `%d` * timescale#3111 Fix `CMAKE_BUILD_TYPE` check **Thanks** * @Dead2, @dv8472 and @einsibjarni for reporting an issue with multinode queries and views * @hperez75 for reporting an issue with Skip Scan

`index` test was moved into SQL test template in #3123 and `generated_columns` - in #2927. They are added to relevant gitignore.

`index` test was moved into SQL test template in timescale#3123 and `generated_columns` - in timescale#2927. They are added to relevant gitignore.

@Dead2

This maintenance release contains bugfixes since the 2.1.0 release. We deem it high priority for upgrading. This release adds support for Skip Scan on multinode by enabling the pushdown of `DISTINCT` to data nodes and also fixes a number of bugs in the implementation of Skip Scan. **Features** * timescale#3113 Pushdown "SELECT DISTINCT" in multi-node to allow use of Skip Scan **Bugfixes** * timescale#3101 Use commit date in `get_git_commit()` * timescale#3104 Fix use after free in `add_reorder_policy` * timescale#3106 Fix use after free in `chunk_api_get_chunk_stats` * timescale#3123 Fix crash while using `REINDEX TABLE CONCURRENTLY` * timescale#3135 Fix SkipScan path generation in `DISTINCT` queries with expressions * timescale#3146 Fix SkipScan for IndexPaths without pathkeys * timescale#3151 Fix `fdw_relinfo_get` assertion failure on DELETE * timescale#3155 Inherit CFLAGS from PostgreSQL * timescale#3109 Copy recreated object permissions on update * timescale#3148 Make `SELECT DISTINCT` handle non-var targetlists * timescale#3147 Skip ChunkAppend if AppendPath has no children * timescale#3102 Fix REINDEX TABLE for distributed hypertables * timescale#3118 Fix use after free in cache * timescale#3112 Use `%u` to format Oid instead of `%d` * timescale#3111 Fix `CMAKE_BUILD_TYPE` check **Thanks** * @Dead2, @dv8472 and @einsibjarni for reporting an issue with multinode queries and views * @hperez75 for reporting an issue with Skip Scan

@Dead2

This maintenance release contains bugfixes since the 2.1.0 release. We deem it high priority for upgrading. This release adds support for Skip Scan on multinode by enabling the pushdown of `DISTINCT` to data nodes and also fixes a number of bugs in the implementation of Skip Scan. **Features** * timescale#3113 Pushdown "SELECT DISTINCT" in multi-node to allow use of Skip Scan **Bugfixes** * timescale#3101 Use commit date in `get_git_commit()` * timescale#3104 Fix use after free in `add_reorder_policy` * timescale#3106 Fix use after free in `chunk_api_get_chunk_stats` * timescale#3123 Fix crash while using `REINDEX TABLE CONCURRENTLY` * timescale#3135 Fix SkipScan path generation in `DISTINCT` queries with expressions * timescale#3146 Fix SkipScan for IndexPaths without pathkeys * timescale#3151 Fix `fdw_relinfo_get` assertion failure on DELETE * timescale#3155 Inherit CFLAGS from PostgreSQL * timescale#3109 Copy recreated object permissions on update * timescale#3148 Make `SELECT DISTINCT` handle non-var targetlists * timescale#3147 Skip ChunkAppend if AppendPath has no children * timescale#3102 Fix REINDEX TABLE for distributed hypertables * timescale#3118 Fix use after free in cache * timescale#3112 Use `%u` to format Oid instead of `%d` * timescale#3111 Fix `CMAKE_BUILD_TYPE` check **Thanks** * @Dead2, @dv8472 and @einsibjarni for reporting an issue with multinode queries and views * @hperez75 for reporting an issue with Skip Scan

@Dead2

This maintenance release contains bugfixes since the 2.1.0 release. We deem it high priority for upgrading. This release extends Skip Scan to multinode by enabling the pushdown of `DISTINCT` to data nodes. It also fixes a number of bugs in the implementation of Skip Scan. **Features** * timescale#3113 Pushdown "SELECT DISTINCT" in multi-node to allow use of Skip Scan **Bugfixes** * timescale#3101 Use commit date in `get_git_commit()` * timescale#3102 Fix `REINDEX TABLE` for distributed hypertables * timescale#3104 Fix use after free in `add_reorder_policy` * timescale#3106 Fix use after free in `chunk_api_get_chunk_stats` * timescale#3109 Copy recreated object permissions on update * timescale#3111 Fix `CMAKE_BUILD_TYPE` check * timescale#3112 Use `%u` to format Oid instead of `%d` * timescale#3118 Fix use after free in cache * timescale#3123 Fix crash while using `REINDEX TABLE CONCURRENTLY` * timescale#3135 Fix SkipScan path generation in `DISTINCT` queries with expressions * timescale#3146 Fix SkipScan for IndexPaths without pathkeys * timescale#3147 Skip ChunkAppend if AppendPath has no children * timescale#3148 Make `SELECT DISTINCT` handle non-var targetlists * timescale#3151 Fix `fdw_relinfo_get` assertion failure on `DELETE` * timescale#3155 Inherit `CFLAGS` from PostgreSQL * timescale#3169 Fix incorrect type cast in compression policy **Thanks** * @Dead2, @dv8472 and @einsibjarni for reporting an issue with multinode queries and views * @hperez75 for reporting an issue with Skip Scan * @nathanloisel for reporting an issue with compression on hypertables with integer-based timestamps * @xin-hedera for fixing an issue with compression on hypertables with integer-based timestamps

@Dead2

This maintenance release contains bugfixes since the 2.1.0 release. We deem it high priority for upgrading. This release extends Skip Scan to multinode by enabling the pushdown of `DISTINCT` to data nodes. It also fixes a number of bugs in the implementation of Skip Scan. **Features** * timescale#3113 Pushdown "SELECT DISTINCT" in multi-node to allow use of Skip Scan **Bugfixes** * timescale#3101 Use commit date in `get_git_commit()` * timescale#3102 Fix `REINDEX TABLE` for distributed hypertables * timescale#3104 Fix use after free in `add_reorder_policy` * timescale#3106 Fix use after free in `chunk_api_get_chunk_stats` * timescale#3109 Copy recreated object permissions on update * timescale#3111 Fix `CMAKE_BUILD_TYPE` check * timescale#3112 Use `%u` to format Oid instead of `%d` * timescale#3118 Fix use after free in cache * timescale#3123 Fix crash while using `REINDEX TABLE CONCURRENTLY` * timescale#3135 Fix SkipScan path generation in `DISTINCT` queries with expressions * timescale#3146 Fix SkipScan for IndexPaths without pathkeys * timescale#3147 Skip ChunkAppend if AppendPath has no children * timescale#3148 Make `SELECT DISTINCT` handle non-var targetlists * timescale#3151 Fix `fdw_relinfo_get` assertion failure on `DELETE` * timescale#3155 Inherit `CFLAGS` from PostgreSQL * timescale#3169 Fix incorrect type cast in compression policy **Thanks** * @Dead2, @dv8472 and @einsibjarni for reporting an issue with multinode queries and views * @hperez75 for reporting an issue with Skip Scan * @nathanloisel for reporting an issue with compression on hypertables with integer-based timestamps * @xin-hedera for fixing an issue with compression on hypertables with integer-based timestamps

@Dead2

This maintenance release contains bugfixes since the 2.1.0 release. We deem it high priority for upgrading. This release extends Skip Scan to multinode by enabling the pushdown of `DISTINCT` to data nodes. It also fixes a number of bugs in the implementation of Skip Scan, in distributed hypertables, in creation of indexes, in compression, and in policies. **Features** * timescale#3113 Pushdown "SELECT DISTINCT" in multi-node to allow use of Skip Scan **Bugfixes** * timescale#3101 Use commit date in `get_git_commit()` * timescale#3102 Fix `REINDEX TABLE` for distributed hypertables * timescale#3104 Fix use after free in `add_reorder_policy` * timescale#3106 Fix use after free in `chunk_api_get_chunk_stats` * timescale#3109 Copy recreated object permissions on update * timescale#3111 Fix `CMAKE_BUILD_TYPE` check * timescale#3112 Use `%u` to format Oid instead of `%d` * timescale#3118 Fix use after free in cache * timescale#3123 Fix crash while using `REINDEX TABLE CONCURRENTLY` * timescale#3135 Fix SkipScan path generation in `DISTINCT` queries with expressions * timescale#3146 Fix SkipScan for IndexPaths without pathkeys * timescale#3147 Skip ChunkAppend if AppendPath has no children * timescale#3148 Make `SELECT DISTINCT` handle non-var targetlists * timescale#3151 Fix `fdw_relinfo_get` assertion failure on `DELETE` * timescale#3155 Inherit `CFLAGS` from PostgreSQL * timescale#3169 Fix incorrect type cast in compression policy **Thanks** * @Dead2, @dv8472 and @einsibjarni for reporting an issue with multinode queries and views * @hperez75 for reporting an issue with Skip Scan * @nathanloisel for reporting an issue with compression on hypertables with integer-based timestamps * @xin-hedera for fixing an issue with compression on hypertables with integer-based timestamps

@Dead2

This maintenance release contains bugfixes since the 2.2.0 release. We deem it high priority for upgrading. This release extends Skip Scan to multinode by enabling the pushdown of `DISTINCT` to data nodes. It also fixes a number of bugs in the implementation of Skip Scan, in distributed hypertables, in creation of indexes, in compression, and in policies. **Features** * timescale#3113 Pushdown "SELECT DISTINCT" in multi-node to allow use of Skip Scan **Bugfixes** * timescale#3101 Use commit date in `get_git_commit()` * timescale#3102 Fix `REINDEX TABLE` for distributed hypertables * timescale#3104 Fix use after free in `add_reorder_policy` * timescale#3106 Fix use after free in `chunk_api_get_chunk_stats` * timescale#3109 Copy recreated object permissions on update * timescale#3111 Fix `CMAKE_BUILD_TYPE` check * timescale#3112 Use `%u` to format Oid instead of `%d` * timescale#3118 Fix use after free in cache * timescale#3123 Fix crash while using `REINDEX TABLE CONCURRENTLY` * timescale#3135 Fix SkipScan path generation in `DISTINCT` queries with expressions * timescale#3146 Fix SkipScan for IndexPaths without pathkeys * timescale#3147 Skip ChunkAppend if AppendPath has no children * timescale#3148 Make `SELECT DISTINCT` handle non-var targetlists * timescale#3151 Fix `fdw_relinfo_get` assertion failure on `DELETE` * timescale#3155 Inherit `CFLAGS` from PostgreSQL * timescale#3169 Fix incorrect type cast in compression policy * timescale#3183 Fix segfault in calculate_chunk_interval * timescale#3185 Fix wrong datatype in integer based retention policy **Thanks** * @Dead2, @dv8472 and @einsibjarni for reporting an issue with multinode queries and views * @hperez75 for reporting an issue with Skip Scan * @nathanloisel for reporting an issue with compression on hypertables with integer-based timestamps * @xin-hedera for fixing an issue with compression on hypertables with integer-based timestamps

@Dead2

This maintenance release contains bugfixes since the 2.2.0 release. We deem it high priority for upgrading. This release extends Skip Scan to multinode by enabling the pushdown of `DISTINCT` to data nodes. It also fixes a number of bugs in the implementation of Skip Scan, in distributed hypertables, in creation of indexes, in compression, and in policies. **Features** * #3113 Pushdown "SELECT DISTINCT" in multi-node to allow use of Skip Scan **Bugfixes** * #3101 Use commit date in `get_git_commit()` * #3102 Fix `REINDEX TABLE` for distributed hypertables * #3104 Fix use after free in `add_reorder_policy` * #3106 Fix use after free in `chunk_api_get_chunk_stats` * #3109 Copy recreated object permissions on update * #3111 Fix `CMAKE_BUILD_TYPE` check * #3112 Use `%u` to format Oid instead of `%d` * #3118 Fix use after free in cache * #3123 Fix crash while using `REINDEX TABLE CONCURRENTLY` * #3135 Fix SkipScan path generation in `DISTINCT` queries with expressions * #3146 Fix SkipScan for IndexPaths without pathkeys * #3147 Skip ChunkAppend if AppendPath has no children * #3148 Make `SELECT DISTINCT` handle non-var targetlists * #3151 Fix `fdw_relinfo_get` assertion failure on `DELETE` * #3155 Inherit `CFLAGS` from PostgreSQL * #3169 Fix incorrect type cast in compression policy * #3183 Fix segfault in calculate_chunk_interval * #3185 Fix wrong datatype in integer based retention policy **Thanks** * @Dead2, @dv8472 and @einsibjarni for reporting an issue with multinode queries and views * @hperez75 for reporting an issue with Skip Scan * @nathanloisel for reporting an issue with compression on hypertables with integer-based timestamps * @xin-hedera for fixing an issue with compression on hypertables with integer-based timestamps

@Dead2

This maintenance release contains bugfixes since the 2.2.0 release. We deem it high priority for upgrading. This release extends Skip Scan to multinode by enabling the pushdown of `DISTINCT` to data nodes. It also fixes a number of bugs in the implementation of Skip Scan, in distributed hypertables, in creation of indexes, in compression, and in policies. **Features** * timescale#3113 Pushdown "SELECT DISTINCT" in multi-node to allow use of Skip Scan **Bugfixes** * timescale#3101 Use commit date in `get_git_commit()` * timescale#3102 Fix `REINDEX TABLE` for distributed hypertables * timescale#3104 Fix use after free in `add_reorder_policy` * timescale#3106 Fix use after free in `chunk_api_get_chunk_stats` * timescale#3109 Copy recreated object permissions on update * timescale#3111 Fix `CMAKE_BUILD_TYPE` check * timescale#3112 Use `%u` to format Oid instead of `%d` * timescale#3118 Fix use after free in cache * timescale#3123 Fix crash while using `REINDEX TABLE CONCURRENTLY` * timescale#3135 Fix SkipScan path generation in `DISTINCT` queries with expressions * timescale#3146 Fix SkipScan for IndexPaths without pathkeys * timescale#3147 Skip ChunkAppend if AppendPath has no children * timescale#3148 Make `SELECT DISTINCT` handle non-var targetlists * timescale#3151 Fix `fdw_relinfo_get` assertion failure on `DELETE` * timescale#3155 Inherit `CFLAGS` from PostgreSQL * timescale#3169 Fix incorrect type cast in compression policy * timescale#3183 Fix segfault in calculate_chunk_interval * timescale#3185 Fix wrong datatype in integer based retention policy **Thanks** * @Dead2, @dv8472 and @einsibjarni for reporting an issue with multinode queries and views * @hperez75 for reporting an issue with Skip Scan * @nathanloisel for reporting an issue with compression on hypertables with integer-based timestamps * @xin-hedera for fixing an issue with compression on hypertables with integer-based timestamps

`index` test was moved into SQL test template in #3123 and `generated_columns` - in #2927. They are added to relevant gitignore.

@Dead2

This maintenance release contains bugfixes since the 2.2.0 release. We deem it high priority for upgrading. This release extends Skip Scan to multinode by enabling the pushdown of `DISTINCT` to data nodes. It also fixes a number of bugs in the implementation of Skip Scan, in distributed hypertables, in creation of indexes, in compression, and in policies. **Features** * #3113 Pushdown "SELECT DISTINCT" in multi-node to allow use of Skip Scan **Bugfixes** * #3101 Use commit date in `get_git_commit()` * #3102 Fix `REINDEX TABLE` for distributed hypertables * #3104 Fix use after free in `add_reorder_policy` * #3106 Fix use after free in `chunk_api_get_chunk_stats` * #3109 Copy recreated object permissions on update * #3111 Fix `CMAKE_BUILD_TYPE` check * #3112 Use `%u` to format Oid instead of `%d` * #3118 Fix use after free in cache * #3123 Fix crash while using `REINDEX TABLE CONCURRENTLY` * #3135 Fix SkipScan path generation in `DISTINCT` queries with expressions * #3146 Fix SkipScan for IndexPaths without pathkeys * #3147 Skip ChunkAppend if AppendPath has no children * #3148 Make `SELECT DISTINCT` handle non-var targetlists * #3151 Fix `fdw_relinfo_get` assertion failure on `DELETE` * #3155 Inherit `CFLAGS` from PostgreSQL * #3169 Fix incorrect type cast in compression policy * #3183 Fix segfault in calculate_chunk_interval * #3185 Fix wrong datatype in integer based retention policy **Thanks** * @Dead2, @dv8472 and @einsibjarni for reporting an issue with multinode queries and views * @hperez75 for reporting an issue with Skip Scan * @nathanloisel for reporting an issue with compression on hypertables with integer-based timestamps * @xin-hedera for fixing an issue with compression on hypertables with integer-based timestamps

pmwkaa requested a review from a team as a code owner April 15, 2021 13:30

pmwkaa requested review from k-rus, mfundul, gayyappan and a team and removed request for a team April 15, 2021 13:30

svenklemm approved these changes Apr 15, 2021

View reviewed changes

erimatnor reviewed Apr 16, 2021

View reviewed changes

pmwkaa force-pushed the reindex_cc_fix branch from 733e7c7 to 58ed20b Compare April 16, 2021 09:43

pmwkaa requested a review from erimatnor April 16, 2021 09:50

pmwkaa force-pushed the reindex_cc_fix branch 3 times, most recently from bea230f to cd41ea1 Compare April 16, 2021 10:22

gayyappan approved these changes Apr 16, 2021

View reviewed changes

test/sql/CMakeLists.txt Show resolved Hide resolved

pmwkaa force-pushed the reindex_cc_fix branch from cd41ea1 to 59b7e46 Compare April 19, 2021 09:52

Fix crash while using REINDEX TABLE CONCURRENTLY

f51f1d3

CONCURRENTLY option of the REINDEX TABLE is not supported and leads to a crash when using with hypertable. Block it and print the error message. Fix timescale#3122

pmwkaa force-pushed the reindex_cc_fix branch from 59b7e46 to f51f1d3 Compare April 19, 2021 10:20

pmwkaa merged commit 20fd421 into timescale:master Apr 19, 2021

k-rus added a commit to k-rus/timescaledb that referenced this pull request Apr 21, 2021

Add new SQL test template files into gitignores

03ee41a

index text was moved into SQL test template in timescale#3123 and generated_columns - in timescale#2927.

k-rus added a commit to k-rus/timescaledb that referenced this pull request Apr 21, 2021

Ignore generated SQL test files from templates

eb27f15

`index` test was moved into SQL test template in timescale#3123 and `generated_columns` - in timescale#2927. They are added to relevant gitignore.

k-rus mentioned this pull request Apr 21, 2021

Ignore generated SQL test files from templates #3141

Merged

k-rus added a commit that referenced this pull request Apr 21, 2021

Ignore generated SQL test files from templates

507b5e5

`index` test was moved into SQL test template in #3123 and `generated_columns` - in #2927. They are added to relevant gitignore.

mkindahl mentioned this pull request Apr 28, 2021

Release 2.2.1 #3167

Merged

mkindahl pushed a commit that referenced this pull request Apr 29, 2021

Ignore generated SQL test files from templates

ae52498

`index` test was moved into SQL test template in #3123 and `generated_columns` - in #2927. They are added to relevant gitignore.

mkindahl pushed a commit that referenced this pull request May 5, 2021

Ignore generated SQL test files from templates

a7e5143

`index` test was moved into SQL test template in #3123 and `generated_columns` - in #2927. They are added to relevant gitignore.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix crash while using REINDEX TABLE CONCURRENTLY #3123

Fix crash while using REINDEX TABLE CONCURRENTLY #3123

pmwkaa commented Apr 15, 2021 •

edited

codecov bot commented Apr 15, 2021 •

edited

pmwkaa commented Apr 15, 2021

erimatnor Apr 16, 2021

pmwkaa Apr 16, 2021 •

edited

erimatnor Apr 16, 2021

pmwkaa Apr 16, 2021 •

edited

erimatnor Apr 16, 2021

gayyappan left a comment

svenklemm commented Apr 17, 2021

	(errmsg("REINDEX TABLE CONCURRENTLY is unsupported on a hypertable"),
	(errmsg("concurrent index creation on hypertables is not supported"),

	errdetail("Using non-concurrent implementation.")));
	errdetail("Performing non-concurrent reindexing instead.")));

Fix crash while using REINDEX TABLE CONCURRENTLY #3123

Fix crash while using REINDEX TABLE CONCURRENTLY #3123

Conversation

pmwkaa commented Apr 15, 2021 • edited

codecov bot commented Apr 15, 2021 • edited

Codecov Report

pmwkaa commented Apr 15, 2021

erimatnor Apr 16, 2021

Choose a reason for hiding this comment

pmwkaa Apr 16, 2021 • edited

Choose a reason for hiding this comment

erimatnor Apr 16, 2021

Choose a reason for hiding this comment

pmwkaa Apr 16, 2021 • edited

Choose a reason for hiding this comment

erimatnor Apr 16, 2021

Choose a reason for hiding this comment

gayyappan left a comment

Choose a reason for hiding this comment

svenklemm commented Apr 17, 2021

pmwkaa commented Apr 15, 2021 •

edited

codecov bot commented Apr 15, 2021 •

edited

pmwkaa Apr 16, 2021 •

edited

pmwkaa Apr 16, 2021 •

edited