Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ExecComputeStoredGeneratedCompat macro #3301

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

svenklemm
Copy link
Member

@svenklemm svenklemm commented Jun 4, 2021

When adding support for PG13 we introduced a macro to hide the
function signature differences of ExecComputeStoredGenerated
but the callers of this function never got adjusted to use the
macro.

@svenklemm svenklemm requested a review from a team as a code owner June 4, 2021 08:47
@svenklemm svenklemm requested review from pmwkaa, afiskon and erimatnor and removed request for a team June 4, 2021 08:47
@svenklemm svenklemm self-assigned this Jun 4, 2021
@codecov
Copy link

codecov bot commented Jun 4, 2021

Codecov Report

Merging #3301 (99a19e5) into master (5719c50) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3301      +/-   ##
==========================================
- Coverage   90.51%   90.48%   -0.03%     
==========================================
  Files         212      212              
  Lines       35494    35444      -50     
==========================================
- Hits        32128    32073      -55     
- Misses       3366     3371       +5     
Impacted Files Coverage Δ
src/copy.c 90.61% <100.00%> (+0.17%) ⬆️
tsl/src/nodes/data_node_copy.c 95.58% <100.00%> (ø)
tsl/src/nodes/data_node_dispatch.c 97.08% <100.00%> (-0.25%) ⬇️
src/loader/bgw_message_queue.c 85.52% <0.00%> (-2.64%) ⬇️
src/import/planner.c 68.96% <0.00%> (-0.77%) ⬇️
src/chunk_append/explain.c 82.53% <0.00%> (-0.28%) ⬇️
src/plan_expand_hypertable.c 93.75% <0.00%> (-0.27%) ⬇️
src/chunk_append/transform.c 96.42% <0.00%> (-0.24%) ⬇️
src/bgw/scheduler.c 82.89% <0.00%> (-0.16%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e1273c...99a19e5. Read the comment docs.

@svenklemm svenklemm requested a review from mfundul June 4, 2021 19:15
Copy link
Contributor

@mkindahl mkindahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Checked if there were other missing locations, but chunk_dispatch_state.c was already correct.

When adding support for PG13 we introduced a macro hide the
function signature differences of ExecComputeStoredGenerated
but the callers of this function never got adjusted to use the
macro.
@svenklemm svenklemm merged commit 7e39797 into timescale:master Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants