Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust code to PG14 reltuples changes #3370

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

svenklemm
Copy link
Member

PG14 changes the initial value of pg_class.reltuples to -1 to allow
differentiating between an empty relation and a relation where
ANALYZE has not yet run.

postgres/postgres@3d351d916b

@svenklemm svenklemm requested a review from a team as a code owner June 28, 2021 09:42
@svenklemm svenklemm requested review from pmwkaa, afiskon, mfundul, gayyappan and mkindahl and removed request for a team June 28, 2021 09:42
@codecov
Copy link

codecov bot commented Jun 28, 2021

Codecov Report

Merging #3370 (4d42d6a) into master (001f5d9) will decrease coverage by 1.57%.
The diff coverage is 88.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3370      +/-   ##
==========================================
- Coverage   92.17%   90.59%   -1.58%     
==========================================
  Files         110      212     +102     
  Lines       14177    35621   +21444     
==========================================
+ Hits        13067    32272   +19205     
- Misses       1110     3349    +2239     
Impacted Files Coverage Δ
src/bgw/launcher_interface.c 72.22% <ø> (+1.63%) ⬆️
src/catalog.h 100.00% <ø> (ø)
src/chunk.c 95.90% <ø> (+1.37%) ⬆️
src/chunk.h 100.00% <ø> (ø)
src/chunk_adaptive.c 92.57% <ø> (+2.78%) ⬆️
src/chunk_append/chunk_append.c 97.41% <ø> (+0.90%) ⬆️
src/chunk_append/exec.c 95.84% <ø> (+1.66%) ⬆️
src/chunk_append/explain.c 82.81% <ø> (ø)
src/chunk_append/planner.c 93.38% <ø> (-2.27%) ⬇️
src/chunk_append/transform.c 96.66% <ø> (-3.34%) ⬇️
... and 280 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e28b9d0...4d42d6a. Read the comment docs.

PG14 changes the initial value of pg_class.reltuples to -1 to allow
differentiating between an empty relation and a relation where
ANALYZE has not yet run.

postgres/postgres@3d351d916b
Copy link
Contributor

@mkindahl mkindahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svenklemm svenklemm merged commit ff5d7e4 into timescale:master Jun 29, 2021
@svenklemm svenklemm deleted the pg14_reltuples branch June 29, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants