Fix time_bucket_ng() behavior with origin argument
#3527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes a silly bug in the time_bucket_ng() implementation:
SELECT time_bucket_ng(
'1 day',
timestamp '2021-07-12 12:34:56',
origin => timestamp '2021-06-01 00:00:00'
);
Before the patch: 2000-02-11 00:00:00
After the patch: 2021-07-12 00:00:00
The tests cath this, but we didn't notice the wrong results :(
mfundul
approved these changes
Aug 26, 2021
Codecov Report
@@ Coverage Diff @@
## master #3527 +/- ##
==========================================
+ Coverage 90.56% 90.69% +0.13%
==========================================
Files 211 212 +1
Lines 35475 36278 +803
==========================================
+ Hits 32127 32902 +775
- Misses 3348 3376 +28
Continue to review full report at Codecov.
|
mkindahl
approved these changes
Aug 26, 2021
svenklemm
added a commit
to svenklemm/timescaledb
that referenced
this pull request
Sep 20, 2021
This release contains bug fixes since the 2.4.1 release. We deem it high priority to upgrade. **Bugfixes** * timescale#3437 Rename on all continuous aggregate objects * timescale#3469 Use signal-safe functions in signal handler * timescale#3520 Modify compression job processing logic * timescale#3527 Fix time_bucket_ng behaviour with origin argument * timescale#3532 Fix bootstrap with regresschecks disabled * timescale#3574 Fix failure on job execution by background worker * timescale#3590 Call cleanup functions on backend exit **Thanks** * @jankatins for reporting a crash with background workers * @LutzWeischerFujitsu for reporting an issue with bootstrap
Merged
svenklemm
added a commit
that referenced
this pull request
Sep 20, 2021
This release contains bug fixes since the 2.4.1 release. We deem it high priority to upgrade. **Bugfixes** * #3437 Rename on all continuous aggregate objects * #3469 Use signal-safe functions in signal handler * #3520 Modify compression job processing logic * #3527 Fix time_bucket_ng behaviour with origin argument * #3532 Fix bootstrap with regresschecks disabled * #3574 Fix failure on job execution by background worker * #3590 Call cleanup functions on backend exit **Thanks** * @jankatins for reporting a crash with background workers * @LutzWeischerFujitsu for reporting an issue with bootstrap
svenklemm
added a commit
that referenced
this pull request
Sep 20, 2021
This release contains bug fixes since the 2.4.1 release. We deem it high priority to upgrade. **Bugfixes** * #3437 Rename on all continuous aggregate objects * #3469 Use signal-safe functions in signal handler * #3520 Modify compression job processing logic * #3527 Fix time_bucket_ng behaviour with origin argument * #3532 Fix bootstrap with regresschecks disabled * #3574 Fix failure on job execution by background worker * #3590 Call cleanup functions on backend exit **Thanks** * @jankatins for reporting a crash with background workers * @LutzWeischerFujitsu for reporting an issue with bootstrap
svenklemm
added a commit
that referenced
this pull request
Sep 20, 2021
This release contains bug fixes since the 2.4.1 release. We deem it high priority to upgrade. **Bugfixes** * #3437 Rename on all continuous aggregate objects * #3469 Use signal-safe functions in signal handler * #3520 Modify compression job processing logic * #3527 Fix time_bucket_ng behaviour with origin argument * #3532 Fix bootstrap with regresschecks disabled * #3574 Fix failure on job execution by background worker * #3590 Call cleanup functions on backend exit **Thanks** * @jankatins for reporting a crash with background workers * @LutzWeischerFujitsu for reporting an issue with bootstrap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a silly bug in the time_bucket_ng() implementation:
SELECT time_bucket_ng(
'1 day',
timestamp '2021-07-12 12:34:56',
origin => timestamp '2021-06-01 00:00:00'
);
Before the patch: 2000-02-11 00:00:00
After the patch: 2021-07-12 00:00:00
The tests cath this, but we didn't notice the wrong results :(