Ensure compression policy has a snapshot #3649
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3649 +/- ##
==========================================
- Coverage 90.80% 90.77% -0.03%
==========================================
Files 212 212
Lines 36528 36539 +11
==========================================
+ Hits 33168 33169 +1
- Misses 3360 3370 +10
Continue to review full report at Codecov.
|
mkindahl
force-pushed
the
compress-job-use-snapshot
branch
from
3fb27a2
to
2c4f049
Compare
mkindahl
changed the title
mkindahl
force-pushed
the
compress-job-use-snapshot
branch
2 times, most recently
from
98ee770
to
de8f735
Compare
Make sure that the compression job works correctly after inserting data into a compressed table.
When compression is running, `init_toast_snapshot` require an active snapshot to work. This function is, among other locations, called from `heap_prepare_insert` and `heap_update` when it is necessary to toast the tuple. Starting a new transaction without a snapshot will fail with the error "cannot fetch toast data without an active snapshot". This commit avoids the problem by pushing an active snapshot after starting a transaction in the compress and recompress policy routines. Fixes timescale#3656
mkindahl
force-pushed
the
compress-job-use-snapshot
branch
from
de8f735
to
44c33a9
Compare
mkindahl
requested review from
berkley,
svenklemm,
duncan-tsdb and
gayyappan
and removed request for
a team and
berkley
|
Closing in favor of #3667 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compression is running,
init_toast_snapshotrequire an activesnapshot to work. This function is, among other locations, called from
heap_prepare_insertandheap_updatewhen it is necessary to toastthe tuple. Starting a new transaction without a snapshot will fail with
the error "cannot fetch toast data without an active snapshot".
This commit avoids the problem by pushing an active snapshot after
starting a transaction in the compress and recompress policy routines.
Fixes #3656