Fix SkipScan crash due to pruned unique path #3881
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When SkipScan paths are added it can result in a crash if the new
SkipScan dominates the PostgreSQL planned unique path. In that case,
the previous unique path is pruned and freed, leading to a potential
memory corruption since a pointer to the original unique path is used
when looping over all subpaths to try to apply SkipScan. Thus, if the
original unique path is pruned, and there are multiple subpaths, a
crash will occur in the next iteration over the subpaths.
The crash is fixed by making a shallow copy of the original unique
path while iterating the subpaths.