Don't redefine PGDLLEXPORT #4413
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code was introduced in 027b7b2 but unfortunatelly the commit message doesn't clarify the need to redefine PGDLLEXORT. It should be defined correctly by Postgres and we shouldn't touch it. This was not a problem until recently. This code is not going to work with the upcoming support of Meson build system in the upstream, and as long as this code is present the extension can't be tested for compatibility with the upstream. Per discussion: https://www.postgresql.org/message-id/20220602152257.szbstfitf3lwdssp%40alap3.anarazel.de
afiskon
requested review from
erimatnor and
svenklemm
and removed request for
a team
|
Nope, it didn't go well. Apparently this should be addressed differently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was introduced in 027b7b2 but unfortunatelly the commit message
doesn't clarify the need to redefine PGDLLEXORT. It should be defined correctly
by Postgres and we shouldn't touch it.
This was not a problem until recently. This code is not going to work with
the upcoming support of Meson build system in the upstream, and as long as
this code is present the extension can't be tested for compatibility with
the upstream.
Per discussion:
https://www.postgresql.org/message-id/20220602152257.szbstfitf3lwdssp%40alap3.anarazel.de