Do not clobber the baserel cache on UDF error #4890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4890 +/- ##
==========================================
+ Coverage 89.46% 89.59% +0.12%
==========================================
Files 225 225
Lines 50288 50146 -142
==========================================
- Hits 44992 44928 -64
+ Misses 5296 5218 -78
Continue to review full report at Codecov.
|
akuzm
commented
Oct 27, 2022
Comment on lines
+443
to
+448
| /* | ||
| * Volatile is needed because these are the local variables that are | ||
| * modified between setjmp/longjmp calls. | ||
| */ | ||
| volatile bool reset_fetcher_type = false; | ||
| volatile bool reset_baserel_info = false; |
There was a problem hiding this comment.
So that's what the -Wclobbered warning was about... I'll fix the other places separately.
fabriziomello
approved these changes
Oct 28, 2022
svenklemm
approved these changes
Nov 1, 2022
The baserel cache should only be allocated and freed by the top-level query.
The one in job_stat.c could probably lead to errors.
|
Backports should also include this commit to remove the accidental debug output: 9964ba8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The baserel cache should only be allocated and freed by the top-level query.
Also enable and fix -Wclobbered which could have prevented this error.
Fixes #4823
Disable-check: commit-count