Make data node calls non-blocking and interruptible #5058
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erimatnor
force-pushed
the
non-blocking-connections
branch
11 times, most recently
from
ec5f276
to
31b8339
Compare
Codecov Report
@@ Coverage Diff @@
## main #5058 +/- ##
==========================================
- Coverage 89.05% 88.84% -0.22%
==========================================
Files 225 225
Lines 51853 52052 +199
==========================================
+ Hits 46180 46246 +66
- Misses 5673 5806 +133
Continue to review full report at Codecov.
|
erimatnor
force-pushed
the
non-blocking-connections
branch
11 times, most recently
from
1a9b13f
to
677e75a
Compare
erimatnor
added
tech-debt
erimatnor
force-pushed
the
non-blocking-connections
branch
from
677e75a
to
845b780
Compare
erimatnor
force-pushed
the
non-blocking-connections
branch
from
662d892
to
170aa3b
Compare
erimatnor
force-pushed
the
non-blocking-connections
branch
from
170aa3b
to
052f0d4
Compare
nikkhils
approved these changes
Jan 18, 2023
pmwkaa
approved these changes
Jan 18, 2023
| ResetLatch(MyLatch); | ||
| CHECK_FOR_INTERRUPTS(); | ||
| } | ||
| if (event.events & WL_SOCKET_READABLE) |
There was a problem hiding this comment.
Maybe we should check exactly then the read event came from the connection socket here?
There was a problem hiding this comment.
There is only the one possibility, but I can assert it.
|
|
||
| do | ||
| { | ||
| ret = PQisBusy(conn->pg_conn); |
There was a problem hiding this comment.
This part looks good, I was mostly curious about it
| @@ -1809,13 +2024,14 @@ remote_connection_drain(TSConnection *conn, TimestampTz endtime, PGresult **resu | |||
| /* In what follows, do not leak any PGresults on an error. */ | |||
| PG_TRY(); | |||
| { | |||
| ModifyWaitEvent(conn->wes, conn->sockeventpos, WL_SOCKET_READABLE, NULL); | |||
There was a problem hiding this comment.
Why do you need this? all the data could be in the buffer already
erimatnor
force-pushed
the
non-blocking-connections
branch
2 times, most recently
from
7f1ad87
to
37d6056
Compare
erimatnor
changed the title
erimatnor
force-pushed
the
non-blocking-connections
branch
7 times, most recently
from
fb156c6
to
b6e0802
Compare
Broken code caused the async connection module to never send queries using prepared statements. Instead, queries were sent using the parameterized query statement instead. Fix this so that prepared statements are used when created.
Refactor the use of libpq calls to data nodes so that they honor PostgreSQL interrupt handling (e.g., ctrl-c or `statement_timeout`) and don't block unnecessarily. To implement this behavior, data node connections are made non-blocking by default and all `libpq` functions are wrapped to integrate with PostgreSQL's signal handling (via `WaitEventSets`) when waiting for read or write readiness. A change is also made to the life-cycle management of `libpq` objects, including connections, and remote query results. Instead of tying these to transactions, they are now tied to the life-cycle of memory contexts using a callback. In most cases, the memory context a connection is allocated on has the same lifetime as transactions, but not always. For example, the connection cache lives across connections and is using a longer lived memory context. Previously that was handled as a special case where connections were marked to not auto close on transaction end. Closes timescale#4958 Closes timescale#2757
erimatnor
force-pushed
the
non-blocking-connections
branch
from
b6e0802
to
7f4a128
Compare
erimatnor
force-pushed
the
non-blocking-connections
branch
from
839271e
to
4a56906
Compare
|
Splitting this up into smaller PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the use of libpq calls to data nodes so that they honor PostgreSQL interrupt handling (e.g., ctrl-c or
statement_timeout) and don't block unnecessarily.To implement this behavior, data node connections are made non-blocking by default and all
libpqfunctions are wrapped to integrate with PostgreSQL's signal handling (viaWaitEventSets) when waiting for read or write readiness.A change is also made to the life-cycle management of
libpqobjects, including connections, and remote query results. Instead of tying these to transactions, they are now tied to the life-cycle of memory contexts using a callback. In most cases, the memory context a connection is allocated on has the same lifetime as transactions, but not always. For example, the connection cache lives across connections and is using a longer lived memory context. Previously that was handled as a special case where connections were marked to not auto close on transaction end.Closes #4958
Closes #2757