Set cache pointer to null before destroying #5070
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkindahl
force-pushed
the
baserel-cache-destruction
branch
from
b079227
to
9eb3458
Compare
Codecov Report
@@ Coverage Diff @@
## main #5070 +/- ##
==========================================
+ Coverage 89.64% 89.70% +0.06%
==========================================
Files 227 227
Lines 51616 51513 -103
==========================================
- Hits 46270 46210 -60
+ Misses 5346 5303 -43
Continue to review full report at Codecov.
|
A cache is used for the duration of a query to speed up planning time, but when destroying the cache, an error in the destruction would leave the cache pointer pointing to a partially or fully destroyed cache, which would give incorrect cache hits for the next query. This commit changes the order of the assignment so that the cache pointer is cleared before destroying the cache. This will allocate a new cache for the next query, even if the previous destruction had an error. Fixes timescale#4795
mkindahl
force-pushed
the
baserel-cache-destruction
branch
from
9eb3458
to
7127138
Compare
|
Closing issue in favor of #5086. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A cache is used for the duration of a query to speed up planning time, but when destroying the cache, an error in the destruction would leave the cache pointer pointing to a partially or fully destroyed cache, which would give incorrect cache hits for the next query.
This commit changes the order of the assignment so that the cache pointer is cleared before destroying the cache. This will allocate a new cache for the next query, even if the previous destruction had an error.
Fixes #4795