Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't enable clang-tidy by default #5187

Merged
merged 1 commit into from Jan 20, 2023
Merged

Don't enable clang-tidy by default #5187

merged 1 commit into from Jan 20, 2023

Conversation

akuzm
Copy link
Member

@akuzm akuzm commented Jan 16, 2023 •
edited

This is aimed at developers. If we enable it by default, it confuses our users and slows down the build for them.

Fixes #5092

Disable-check: force-changelog-changed

@codecov
Copy link

codecov bot commented Jan 16, 2023 •
edited

Codecov Report

Merging #5187 (3a60dd0) into main (014b7b9) will decrease coverage by 1.68%.
The diff coverage is n/a.

❗ Current head 3a60dd0 differs from pull request most recent head 3204fa4. Consider uploading reports for the commit 3204fa4 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5187      +/-   ##
==========================================
- Coverage   63.14%   61.47%   -1.68%     
==========================================
  Files         225      225              
  Lines       45620    44707     -913     
==========================================
- Hits        28808    27483    -1325     
- Misses      16812    17224     +412
Impacted Files Coverage Δ
tsl/test/src/test_chunk_stats.c 0.00% <0.00%> (-100.00%) ⬇️
src/extension_utils.c 0.00% <0.00%> (-93.19%) ⬇️
src/extension.c 0.00% <0.00%> (-85.72%) ⬇️
tsl/src/nodes/frozen_chunk_dml/frozen_chunk_dml.c 0.00% <0.00%> (-65.91%) ⬇️
tsl/src/chunk.c 33.22% <0.00%> (-62.80%) ⬇️
src/chunk.c 0.72% <0.00%> (-41.57%) ⬇️
src/loader/bgw_launcher.c 53.45% <0.00%> (-35.17%) ⬇️
tsl/src/nodes/compress_dml/compress_dml.c 66.66% <0.00%> (-33.34%) ⬇️
tsl/src/fdw/option.c 0.00% <0.00%> (-19.55%) ⬇️
tsl/src/partialize_finalize.c 86.28% <0.00%> (-9.91%) ⬇️
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 014b7b9...3204fa4. Read the comment docs.

@akuzm
Don't enable clang-tidy by default
3204fa4 
This is aimed at developers. If we enable it by default, it confuses our
users and slows down the build for them.
@akuzm akuzm enabled auto-merge (rebase) January 20, 2023 11:57
@akuzm akuzm merged commit d2254cb into timescale:main Jan 20, 2023
@akuzm akuzm mentioned this pull request Jan 26, 2023
Closed
@mkindahl mkindahl mentioned this pull request Jan 26, 2023
Closed
@akuzm akuzm mentioned this pull request Jan 27, 2023
Closed
@github-actions github-actions bot mentioned this pull request Jan 27, 2023
Closed
@akuzm akuzm mentioned this pull request Jan 27, 2023
Closed
@github-actions github-actions bot mentioned this pull request Jan 27, 2023
Closed
@mkindahl mkindahl mentioned this pull request Jan 27, 2023
Merged
@akuzm akuzm mentioned this pull request Jan 27, 2023
Closed
@lkshminarayanan lkshminarayanan added this to the TimescaleDB 2.9.3 milestone Feb 2, 2023
lkshminarayanan added a commit to lkshminarayanan/timescaledb that referenced this pull request Feb 3, 2023
@lkshminarayanan
Release 2.9.3
122efef 
This release contains bug fixes since the 2.9.2 release.
We recommend that you upgrade at the next available opportunity.

**Bugfixes**
* timescale#4804 Skip bucketing when start or end of refresh job is null
* timescale#5108 Fix column ordering in compressed table index
* timescale#5187 Don't enable clang-tidy by default
* timescale#5255 Fix year not multiple of day/month in nested CAgg
* timescale#5259 Lock down search_path in SPI calls
@lkshminarayanan lkshminarayanan mentioned this pull request Feb 3, 2023
Merged
lkshminarayanan added a commit to lkshminarayanan/timescaledb that referenced this pull request Feb 3, 2023
@lkshminarayanan
Release 2.9.3
6e29a53 
This release contains bug fixes since the 2.9.2 release.
We recommend that you upgrade at the next available opportunity.

**Bugfixes**
* timescale#4804 Skip bucketing when start or end of refresh job is null
* timescale#5108 Fix column ordering in compressed table index
* timescale#5187 Don't enable clang-tidy by default
* timescale#5255 Fix year not multiple of day/month in nested CAgg
* timescale#5259 Lock down search_path in SPI calls
lkshminarayanan added a commit to lkshminarayanan/timescaledb that referenced this pull request Feb 3, 2023
@lkshminarayanan
Release 2.9.3
c56ce87 
This release contains a critical securtiy fix(timescale#5259) and other bug fixes since
the 2.9.2 release.

This release is high priority for upgrade. We strongly recommend that you
upgrade as soon as possible.

**Bugfixes**
* timescale#4804 Skip bucketing when start or end of refresh job is null
* timescale#5108 Fix column ordering in compressed table index
* timescale#5187 Don't enable clang-tidy by default
* timescale#5255 Fix year not multiple of day/month in nested CAgg
* timescale#5259 Lock down search_path in SPI calls
lkshminarayanan added a commit to lkshminarayanan/timescaledb that referenced this pull request Feb 3, 2023
@lkshminarayanan
Release 2.9.3
4e433ef 
This release contains a critical securtiy fix(timescale#5259) and other bug fixes since
the 2.9.2 release.

This release is high priority for upgrade. We strongly recommend that you
upgrade as soon as possible.

**Bugfixes**
* timescale#4804 Skip bucketing when start or end of refresh job is null
* timescale#5108 Fix column ordering in compressed table index
* timescale#5187 Don't enable clang-tidy by default
* timescale#5255 Fix year not multiple of day/month in nested CAgg
* timescale#5259 Lock down search_path in SPI calls
lkshminarayanan added a commit to lkshminarayanan/timescaledb that referenced this pull request Feb 3, 2023
@lkshminarayanan
Release 2.9.3
7aa5752 
This release contains a critical securtiy fix(timescale#5259) and other bug fixes
since the 2.9.2 release.

This release is high priority for upgrade. We strongly recommend that
you upgrade as soon as possible.

**Bugfixes**
* timescale#4804 Skip bucketing when start or end of refresh job is null
* timescale#5108 Fix column ordering in compressed table index
* timescale#5187 Don't enable clang-tidy by default
* timescale#5255 Fix year not multiple of day/month in nested CAgg
* timescale#5259 Lock down search_path in SPI calls
lkshminarayanan added a commit to lkshminarayanan/timescaledb that referenced this pull request Feb 3, 2023
@lkshminarayanan
Release 2.9.3
c00aeb5 
This release contains bug fixes since the 2.9.2 release.
This release is high priority for upgrade. We strongly recommend that you
upgrade as soon as possible.

**Bugfixes**
* timescale#4804 Skip bucketing when start or end of refresh job is null
* timescale#5108 Fix column ordering in compressed table index not following the order of a multi-column segment by definition
* timescale#5187 Don't enable clang-tidy by default
* timescale#5255 Fix year not being considered as a multiple of day/month in hierarchical continuous aggregates
* timescale#5259 Lock down search_path in SPI calls
lkshminarayanan added a commit that referenced this pull request Feb 3, 2023
@lkshminarayanan
Release 2.9.3
fb3ad7d 
This release contains bug fixes since the 2.9.2 release.
This release is high priority for upgrade. We strongly recommend that you
upgrade as soon as possible.

**Bugfixes**
* #4804 Skip bucketing when start or end of refresh job is null
* #5108 Fix column ordering in compressed table index not following the order of a multi-column segment by definition
* #5187 Don't enable clang-tidy by default
* #5255 Fix year not being considered as a multiple of day/month in hierarchical continuous aggregates
* #5259 Lock down search_path in SPI calls
lkshminarayanan added a commit to lkshminarayanan/timescaledb that referenced this pull request Feb 3, 2023
@lkshminarayanan
Release 2.9.3
46daf45 
This release contains bug fixes since the 2.9.2 release.
This release is high priority for upgrade. We strongly recommend that you
upgrade as soon as possible.

**Bugfixes**
* timescale#4804 Skip bucketing when start or end of refresh job is null
* timescale#5108 Fix column ordering in compressed table index not following the order of a multi-column segment by definition
* timescale#5187 Don't enable clang-tidy by default
* timescale#5255 Fix year not being considered as a multiple of day/month in hierarchical continuous aggregates
* timescale#5259 Lock down search_path in SPI calls
lkshminarayanan added a commit to lkshminarayanan/timescaledb that referenced this pull request Feb 6, 2023
@lkshminarayanan
Release 2.9.3
0d84155 
This release contains bug fixes since the 2.9.2 release.
This release is high priority for upgrade. We strongly recommend that you
upgrade as soon as possible.

**Bugfixes**
* timescale#4804 Skip bucketing when start or end of refresh job is null
* timescale#5108 Fix column ordering in compressed table index not following the order of a multi-column segment by definition
* timescale#5187 Don't enable clang-tidy by default
* timescale#5255 Fix year not being considered as a multiple of day/month in hierarchical continuous aggregates
* timescale#5259 Lock down search_path in SPI calls
lkshminarayanan added a commit that referenced this pull request Feb 6, 2023
@lkshminarayanan
Release 2.9.3
b88c5a9 
This release contains bug fixes since the 2.9.2 release.
This release is high priority for upgrade. We strongly recommend that you
upgrade as soon as possible.

**Bugfixes**
* #4804 Skip bucketing when start or end of refresh job is null
* #5108 Fix column ordering in compressed table index not following the order of a multi-column segment by definition
* #5187 Don't enable clang-tidy by default
* #5255 Fix year not being considered as a multiple of day/month in hierarchical continuous aggregates
* #5259 Lock down search_path in SPI calls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziomello fabriziomello fabriziomello approved these changes

@svenklemm svenklemm svenklemm approved these changes

Assignees

@akuzm akuzm

Labels
None yet
Projects
None yet
Milestone
TimescaleDB 2.9.3
Development

Successfully merging this pull request may close these issues.

[Bug]: error: Access to field 'ss_ScanTupleSlot' results in a dereference of a null pointer
4 participants
@akuzm @fabriziomello @svenklemm @lkshminarayanan