Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Update community license related errors #5438

Closed
iroussos opened this issue Mar 14, 2023 · 8 comments · Fixed by #5490
Closed

[Enhancement]: Update community license related errors #5438

iroussos opened this issue Mar 14, 2023 · 8 comments · Fixed by #5490
Assignees
@konskov
Labels
enhancement An enhancement to an existing feature for functionality Team: Core Database

Comments

@iroussos
Copy link

iroussos commented Mar 14, 2023 •
edited

What type of enhancement is this?

User experience

What subsystems and features will be improved?

Other

What does the enhancement do?

When users that are running the TimescaleDB Apache 2 Edition try to use a feature only supported on the TimescaleDB Community Edition, they get an error that the feature is only supported in the community license.

Example:

tsdb=> ALTER TABLE test SET ( timescaledb.compress);

ERROR:  functionality not supported under the current "apache" license
HINT:  Upgrade your license to 'timescale' to use this free community feature.

This is a valid message, but we don't provide additional information to our users on how to address that problem or an actionable option if they are interested in doing so. We'd like to standardize those error messages and provide a path forward for users that want to use the Community Edition by linking to our web side and hinting to the best way in our opinion to access all the Timescale features (Timescale Cloud).

Related issue: #5436

Implementation challenges

  • Find all error messages (and warnings if there are any) that mention our license.
  • Update them with a link to https://www.timescale.com/ and a slightly more actionable Hint
- ERROR:  functionality not supported under the current "apache" license
- HINT:  Upgrade your license to 'timescale' to use this free community feature.
+ ERROR:  functionality not supported under the current "apache" license. Learn more at http://timescale.com/.
+ HINT:   to get access to all features, and the best time-series experience try out Timescale Cloud
@iroussos iroussos added enhancement An enhancement to an existing feature for functionality Team: Core Database labels Mar 14, 2023
@iroussos
Copy link
Author

@horzsolt similar to #5436, this should be a minor change that I think we can do outside of regular planning. If you agree, do you mind assigning someone to this issue?

@iroussos
Copy link
Author

@jfjoly @jamessewell @Loquacity for your opinion on the messaging 🙇

@Loquacity
Copy link

I think the way the proposed text reads is that it isn't clear that you're telling people to use Cloud because it resolves the licence issue, it seems more like a generic marketing message ("Try the veal!"). Can we make it read something more like: "The best way to use the timescale licence is to sign up for Timescale Cloud"? That way you're actually linking the error and the CTA.

@jamessewell
Copy link 

ERROR:  functionality not supported under the current "apache" license. Learn more at http://timescale.com/.
HINT:   to get access to all features, and the best time-series experience try out Timescale Cloud

@Loquacity
Copy link 

ERROR:  functionality not supported under the current "apache" license. Learn more at http://timescale.com/.
HINT:   to get access to all features, and the best time-series experience try out Timescale Cloud

You need a second comma after 'experience' to offset the parenthetical clause, but otherwise, LGTM 👍

@iroussos
Copy link
Author

Thank you @Loquacity @jamessewell, I have updated the description with your proposal :-)

@horzsolt this should be ready to be picked by someone on the Database Core team

@konskov konskov self-assigned this Mar 27, 2023
konskov added a commit to konskov/timescaledb that referenced this issue Mar 27, 2023
@konskov
Update community license related errors
eef703e 
Update the error message printed when attempting to use
a community license feature with apache license installed.

Fixes timescale#5438
@konskov konskov mentioned this issue Mar 27, 2023
Merged
konskov added a commit to konskov/timescaledb that referenced this issue Mar 27, 2023
@konskov
Update community license related errors
57fde38 
Update the error message printed when attempting to use
a community license feature with apache license installed.

Fixes timescale#5438
konskov added a commit that referenced this issue Mar 27, 2023
@konskov
Update community license related errors
22841ab 
Update the error message printed when attempting to use
a community license feature with apache license installed.

Fixes #5438
@mfreed
Copy link
Member

mfreed commented Apr 5, 2023 •
edited

To @Loquacity 's comment, the text should read:

To get access to all features and the best time-series experience, try out Timescale Cloud.

not

To get access to all features, and the best time-series experience try out Timescale Cloud.

🙏

Actually, why don't we just simplify:

To access all features and the best time-series experience, try out Timescale Cloud.

@mfreed mfreed reopened this Apr 5, 2023
@konskov
Copy link
Contributor

konskov commented Jun 8, 2023

I think it is ok to close this issue now, since https://github.com//timescale/timescaledb/commit/3814a3f351a0691681e3123631a99e3e5b45aae6 is part of the 2.11 release.

@konskov konskov closed this as completed Jun 8, 2023
@igor2x igor2x mentioned this issue Oct 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@konskov konskov

Labels
enhancement An enhancement to an existing feature for functionality Team: Core Database
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update community license related errors konskov/timescaledb
5 participants
@mfreed @jamessewell @Loquacity @iroussos @konskov