Update community license related errors #5490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mahipv, @fabriziomello: please review this pull request.
|
Codecov Report
@@ Coverage Diff @@
## main #5490 +/- ##
==========================================
- Coverage 90.76% 90.74% -0.02%
==========================================
Files 229 229
Lines 53660 53655 -5
==========================================
- Hits 48703 48689 -14
- Misses 4957 4966 +9
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
akuzm
approved these changes
Mar 27, 2023
There was a problem hiding this comment.
This usually goes to errhint or errdetail I think.
https://www.postgresql.org/docs/current/error-style-guide.html
sb230132
approved these changes
Mar 27, 2023
src/cross_module_fn.c
Outdated
| errmsg("functionality not supported under the current \"%s\" license", ts_guc_license), | ||
| errhint("Upgrade your license to 'timescale' to use this free community feature."))); | ||
| errmsg("functionality not supported under the current \"%s\" license. Learn more at " | ||
| "http://timescale.com/.", |
There was a problem hiding this comment.
good point I think, thank you!
Update the error message printed when attempting to use a community license feature with apache license installed. Fixes timescale#5438
konskov
force-pushed
the
community_license_errors
branch
from
eef703e
to
57fde38
Compare
konskov
added a commit
to konskov/timescaledb
that referenced
this pull request
Apr 6, 2023
Commit 57fde38 changed the messaging but did not format the error hint correctly. This patch fixes the error hint. Fixes timescale#5490
konskov
added a commit
to konskov/timescaledb
that referenced
this pull request
Apr 6, 2023
Commit 57fde38 changed the messaging but did not format the error hint correctly. This patch fixes the error hint. Fixes timescale#5490
konskov
added a commit
to konskov/timescaledb
that referenced
this pull request
Apr 6, 2023
Commit 57fde38 changed the messaging but did not format the error hint correctly. This patch fixes the error hint. Fixes timescale#5490
konskov
added a commit
to konskov/timescaledb
that referenced
this pull request
Apr 6, 2023
Commit 57fde38 changed the messaging but did not format the error hint correctly. This patch fixes the error hint. Fixes timescale#5490
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the error message printed when attempting to use a community license feature with apache license installed.
Fixes #5438