Backport to 2.10.x: #5499: Do not segfault on large histogram() parameters #5503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a bug in `width_bucket()` causing an overflow and subsequent NaN value as a result of dividing with `+inf`. The NaN value is interpreted as an integer and hence generates an index out of range for the buckets. This commit fixes this by generating an error rather than segfaulting for bucket indexes that are out of range. (cherry picked from commit 777c599)
timescale-automation
added
the
is-auto-backport
Codecov Report
@@ Coverage Diff @@
## 2.10.x #5503 +/- ##
=========================================
Coverage ? 90.67%
=========================================
Files ? 226
Lines ? 52099
Branches ? 0
=========================================
Hits ? 47239
Misses ? 4860
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated backport of #5499: Do not segfault on large histogram() parameters.
The original issue is #5489.
This PR will be merged automatically after all the relevant CI checks pass. If this fix should not be backported, or will be backported manually, just close this PR. You can use the backport branch to add your changes, it won't be modified automatically anymore.
For more details, please see the documentation
Original description
Do not segfault on large histogram() parameters
There is a bug in
width_bucket()causing an overflow and subsequent NaN value as a result of dividing with+inf. The NaN value is interpreted as an integer and hence generates an index out of range for the buckets.This commit fixes this by generating an error rather than segfaulting for bucket indexes that are out of range.
Fixes#5489