Enable indexscan on uncompressed part of partially compressed chunks #5589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@akuzm, @lkshminarayanan: please review this pull request.
|
Codecov Report
@@ Coverage Diff @@
## 2.10.x #5589 +/- ##
=========================================
Coverage ? 90.64%
=========================================
Files ? 226
Lines ? 52264
Branches ? 0
=========================================
Hits ? 47376
Misses ? 4888
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This was previously disabled as no data resided on the uncompressed chunk once it was compressed, but this is not the case anymore with partially compressed chunks, so we enable indexscan for the uncompressed chunk again. Fixes timescale#5432 Co-authored-by: Ante Kresic <ante.kresic@gmail.com> (cherry picked from commit 5633960)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously disabled as no data resided on the uncompressed chunk once it was compressed, but this is not the case anymore with partially compressed chunks, so we enable indexscan for the uncompressed chunk again.
Fixes #5432
Co-authored-by: Ante Kresic ante.kresic@gmail.com
(cherry picked from commit 5633960)