Make logrepl markers for (partial) decompressions #5805

noctarius · 2023-06-21T09:37:41Z

Added logical replication messages (PG14+) as markers for (partial) decompression events (mutual compression), which makes it possible to differentiate inserts happening as part of the decompression vs actual inserts by the user, and filter the former out of the event stream. While some tools may be interested in all events, synching the pure "state" (without internal behavior) is required for others.

As of now this PR is missing tests. I wonder if anyone has a good idea how to create an automatic test for it.

github-actions · 2023-06-21T09:38:09Z

@gayyappan, @nikkhils: please review this pull request.

Powered by pull-review

codecov · 2023-06-21T09:51:40Z

Codecov Report

Merging #5805 (0220d2d) into main (8a2b6a0) will increase coverage by 0.76%.
The diff coverage is 84.61%.

❗ Current head 0220d2d differs from pull request most recent head 68b2492. Consider uploading reports for the commit 68b2492 to get more accurate results

@@            Coverage Diff             @@
##             main    #5805      +/-   ##
==========================================
+ Coverage   87.10%   87.87%   +0.76%     
==========================================
  Files         243      239       -4     
  Lines       55915    55800     -115     
  Branches    12377    12360      -17     
==========================================
+ Hits        48704    49032     +328     
+ Misses       4884     4842      -42     
+ Partials     2327     1926     -401

Files Changed	Coverage Δ
tsl/src/compression/compression.c	`91.48% <83.33%> (-0.07%)`	⬇️
src/guc.c	`95.58% <100.00%> (-0.97%)`	⬇️

... and 115 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

kgyrtkirk

made some notes here and-there; otherwise looks good

tsl/src/compression/compression.c

noctarius · 2023-06-25T12:23:21Z

Updated! Any ideas on how to build a test for that?

fabriziomello

Wondering how much overhead we'll have doing it. Did u did some perf tests? Perhaps adding a GUC to turn it on/off (default off) should be appropriate.

Regarding the tests for this kind of change you should create a TAP test.

tsl/src/compression/compression.c

noctarius · 2023-06-26T05:53:06Z

Wondering how much overhead we'll have doing it. Did u did some perf tests? Perhaps adding a GUC to turn it on/off (default off) should be appropriate.

Regarding the tests for this kind of change you should create a TAP test.

No, I didn't performance test it since I wouldn't know how. It should only happen when logical replication is enabled. That said, everyone using logical replication (except PG maybe) would have the same issue. Just not sure if we want to make it a public contract yet (I mean the marker messages). Anyway, this is happening exactly twice per decompression, one start and one end message. I don't expect too much overhead since those messages are just being logged and there isn't even content in the messages.

Happy to add an additional property to prevent it all together, but not sure how that would work 😅

TAP tests seem to be the Perl based tests. Not really into Python. Can somebody help with that? 🫣

noctarius · 2023-06-26T14:15:37Z

I have moved the marker calls closer to the actual decompressor execution to send the end marker before the original user's statement execution.

noctarius · 2023-06-29T13:58:29Z

Added a TAP based test (or at least I tried myself on a test). @fabriziomello can you give it a look and see if that makes sense? :)

noctarius · 2023-06-30T06:37:46Z

Should this show up in the changelog, meaning, should I add a file to create a changelog?

noctarius · 2023-07-03T08:37:44Z

Added SIGHUB GUC which disables the event generation by default: timescaledb.enable_decompression_logrep_markers

tsl/src/compression/compression.c

noctarius · 2023-07-20T19:12:07Z

Anything still missing here? Would be awesome if we'd get that into 2.12 :)

fabriziomello · 2023-07-21T08:34:30Z

Anything still missing here? Would be awesome if we'd get that into 2.12 :)

The pr LGTM but still in doubt about use cases of it.

noctarius · 2023-07-21T09:28:36Z

When you use the logical replication stream there is no way to differentiate an insert (which happens due to an internal decompression - internal behavior) and an actual insert through a user's request. When using the stream to send it to another system (e.g. audit system, or stream engine, or similar) you often have a stateful engine on the other end. Either you get a "duplicate entry" since that system already knows the key / row, or you end up with duplicates.

Imagine you'd try to to replicate the events into another PG database (for example a vanilla PG table, with the root table being resolved and inserts redirected to that root table), you'd end up with duplicate entry errors since the entry already exists (the vanilla table doesn't know about the compression) but with decompression inserts being also redirected to the vanilla table.

This patch makes it possible to understand that between start- and end-markers, all inserts can be discarded since those are inserts due to internal behavior of TimescaleDB. It's basically a way to hide / filter an implementation detail.

noctarius · 2023-08-01T20:17:47Z

ping 😅

Added logical replication messages (PG14+) as markers for (partial) decompression events (mutual compression), which makes it possible to differentiate inserts happening as part of the decompression vs actual inserts by the user, and filter the former out of the event stream. While some tools may be interested in all events, synching the pure "state" (without internal behavior) is required for others.

nikkhils

LGTM

@ajcanterbury

This release contains performance improvements for compressed hypertables and continuous aggregates and bug fixes since the 2.11.2 release. We recommend that you upgrade at the next available opportunity. This release moves all internal functions from the _timescaleb_internal schema into the _timescaledb_functions schema. This separates code from internal data objects and improves security by allowing more restrictive permissions for the code schema. If you are calling any of those internal functions you should adjust your code as soon as possible. This version also includes a compatibility layer that allows calling them in the old location but that layer will be removed in 2.14.0. **PostgreSQL 12 support removal announcement** Following the deprecation announcement for PostgreSQL 12 in TimescaleDB 2.10, PostgreSQL 12 is not supported starting with TimescaleDB 2.12. Currently supported PostgreSQL major versions are 13, 14 and 15. PostgreSQL 16 support will be added with a following TimescaleDB release. **Features** * timescale#5137 Insert into index during chunk compression * timescale#5150 MERGE support on hypertables * timescale#5515 Make hypertables support replica identity * timescale#5586 Index scan support during UPDATE/DELETE on compressed hypertables * timescale#5596 Support for partial aggregations at chunk level * timescale#5599 Enable ChunkAppend for partially compressed chunks * timescale#5655 Improve the number of parallel workers for decompression * timescale#5758 Enable altering job schedule type through `alter_job` * timescale#5805 Make logrepl markers for (partial) decompressions * timescale#5809 Relax invalidation threshold table-level lock to row-level when refreshing a Continuous Aggregate * timescale#5839 Support CAgg names in chunk_detailed_size * timescale#5852 Make set_chunk_time_interval CAggs aware * timescale#5868 Allow ALTER TABLE ... REPLICA IDENTITY (FULL|INDEX) on materialized hypertables (continuous aggregates) * timescale#5875 Add job exit status and runtime to log * timescale#5909 CREATE INDEX ONLY ON hypertable creates index on chunks **Bugfixes** * timescale#5860 Fix interval calculation for hierarchical CAggs * timescale#5894 Check unique indexes when enabling compression * timescale#5951 _timescaledb_internal.create_compressed_chunk doesn't account for existing uncompressed rows * timescale#5988 Move functions to _timescaledb_functions schema * timescale#5788 Chunk_create must add an existing table or fail * timescale#5872 Fix duplicates on partially compressed chunk reads * timescale#5918 Fix crash in COPY from program returning error * timescale#5990 Place data in first/last function in correct mctx * timescale#5991 Call eq_func correctly in time_bucket_gapfill * timescale#6015 Correct row count in EXPLAIN ANALYZE INSERT .. ON CONFLICT output * timescale#6035 Fix server crash on UPDATE of compressed chunk * timescale#6044 Fix server crash when using duplicate segmentby column * timescale#6045 Fix segfault in set_integer_now_func * timescale#6053 Fix approximate_row_count for CAggs * timescale#6081 Improve compressed DML datatype handling * timescale#6084 Propagate parameter changes to decompress child nodes **Thanks** * @ajcanterbury for reporting a problem with lateral joins on compressed chunks * @alexanderlaw for reporting multiple server crashes * @lukaskirner for reporting a bug with monthly continuous aggregates * @mrksngl for reporting a bug with unusual user names * @willsbit for reporting a crash in time_bucket_gapfill

@ajcanterbury

This release contains performance improvements for compressed hypertables and continuous aggregates and bug fixes since the 2.11.2 release. We recommend that you upgrade at the next available opportunity. This release moves all internal functions from the _timescaleb_internal schema into the _timescaledb_functions schema. This separates code from internal data objects and improves security by allowing more restrictive permissions for the code schema. If you are calling any of those internal functions you should adjust your code as soon as possible. This version also includes a compatibility layer that allows calling them in the old location but that layer will be removed in 2.14.0. **PostgreSQL 12 support removal announcement** Following the deprecation announcement for PostgreSQL 12 in TimescaleDB 2.10, PostgreSQL 12 is not supported starting with TimescaleDB 2.12. Currently supported PostgreSQL major versions are 13, 14 and 15. PostgreSQL 16 support will be added with a following TimescaleDB release. **Features** * #5137 Insert into index during chunk compression * #5150 MERGE support on hypertables * #5515 Make hypertables support replica identity * #5586 Index scan support during UPDATE/DELETE on compressed hypertables * #5596 Support for partial aggregations at chunk level * #5599 Enable ChunkAppend for partially compressed chunks * #5655 Improve the number of parallel workers for decompression * #5758 Enable altering job schedule type through `alter_job` * #5805 Make logrepl markers for (partial) decompressions * #5809 Relax invalidation threshold table-level lock to row-level when refreshing a Continuous Aggregate * #5839 Support CAgg names in chunk_detailed_size * #5852 Make set_chunk_time_interval CAggs aware * #5868 Allow ALTER TABLE ... REPLICA IDENTITY (FULL|INDEX) on materialized hypertables (continuous aggregates) * #5875 Add job exit status and runtime to log * #5909 CREATE INDEX ONLY ON hypertable creates index on chunks **Bugfixes** * #5860 Fix interval calculation for hierarchical CAggs * #5894 Check unique indexes when enabling compression * #5951 _timescaledb_internal.create_compressed_chunk doesn't account for existing uncompressed rows * #5988 Move functions to _timescaledb_functions schema * #5788 Chunk_create must add an existing table or fail * #5872 Fix duplicates on partially compressed chunk reads * #5918 Fix crash in COPY from program returning error * #5990 Place data in first/last function in correct mctx * #5991 Call eq_func correctly in time_bucket_gapfill * #6015 Correct row count in EXPLAIN ANALYZE INSERT .. ON CONFLICT output * #6035 Fix server crash on UPDATE of compressed chunk * #6044 Fix server crash when using duplicate segmentby column * #6045 Fix segfault in set_integer_now_func * #6053 Fix approximate_row_count for CAggs * #6081 Improve compressed DML datatype handling * #6084 Propagate parameter changes to decompress child nodes **Thanks** * @ajcanterbury for reporting a problem with lateral joins on compressed chunks * @alexanderlaw for reporting multiple server crashes * @lukaskirner for reporting a bug with monthly continuous aggregates * @mrksngl for reporting a bug with unusual user names * @willsbit for reporting a crash in time_bucket_gapfill

@ajcanterbury

This release contains performance improvements for compressed hypertables and continuous aggregates and bug fixes since the 2.11.2 release. We recommend that you upgrade at the next available opportunity. This release moves all internal functions from the _timescaleb_internal schema into the _timescaledb_functions schema. This separates code from internal data objects and improves security by allowing more restrictive permissions for the code schema. If you are calling any of those internal functions you should adjust your code as soon as possible. This version also includes a compatibility layer that allows calling them in the old location but that layer will be removed in 2.14.0. **PostgreSQL 12 support removal announcement** Following the deprecation announcement for PostgreSQL 12 in TimescaleDB 2.10, PostgreSQL 12 is not supported starting with TimescaleDB 2.12. Currently supported PostgreSQL major versions are 13, 14 and 15. PostgreSQL 16 support will be added with a following TimescaleDB release. **Features** * #5137 Insert into index during chunk compression * #5150 MERGE support on hypertables * #5515 Make hypertables support replica identity * #5586 Index scan support during UPDATE/DELETE on compressed hypertables * #5596 Support for partial aggregations at chunk level * #5599 Enable ChunkAppend for partially compressed chunks * #5655 Improve the number of parallel workers for decompression * #5758 Enable altering job schedule type through `alter_job` * #5805 Make logrepl markers for (partial) decompressions * #5809 Relax invalidation threshold table-level lock to row-level when refreshing a Continuous Aggregate * #5839 Support CAgg names in chunk_detailed_size * #5852 Make set_chunk_time_interval CAggs aware * #5868 Allow ALTER TABLE ... REPLICA IDENTITY (FULL|INDEX) on materialized hypertables (continuous aggregates) * #5875 Add job exit status and runtime to log * #5909 CREATE INDEX ONLY ON hypertable creates index on chunks **Bugfixes** * #5860 Fix interval calculation for hierarchical CAggs * #5894 Check unique indexes when enabling compression * #5951 _timescaledb_internal.create_compressed_chunk doesn't account for existing uncompressed rows * #5988 Move functions to _timescaledb_functions schema * #5788 Chunk_create must add an existing table or fail * #5872 Fix duplicates on partially compressed chunk reads * #5918 Fix crash in COPY from program returning error * #5990 Place data in first/last function in correct mctx * #5991 Call eq_func correctly in time_bucket_gapfill * #6015 Correct row count in EXPLAIN ANALYZE INSERT .. ON CONFLICT output * #6035 Fix server crash on UPDATE of compressed chunk * #6044 Fix server crash when using duplicate segmentby column * #6045 Fix segfault in set_integer_now_func * #6053 Fix approximate_row_count for CAggs * #6081 Improve compressed DML datatype handling * #6084 Propagate parameter changes to decompress child nodes **Thanks** * @ajcanterbury for reporting a problem with lateral joins on compressed chunks * @alexanderlaw for reporting multiple server crashes * @lukaskirner for reporting a bug with monthly continuous aggregates * @mrksngl for reporting a bug with unusual user names * @willsbit for reporting a crash in time_bucket_gapfill

@ajcanterbury

This release contains performance improvements for compressed hypertables and continuous aggregates and bug fixes since the 2.11.2 release. We recommend that you upgrade at the next available opportunity. This release moves all internal functions from the _timescaleb_internal schema into the _timescaledb_functions schema. This separates code from internal data objects and improves security by allowing more restrictive permissions for the code schema. If you are calling any of those internal functions you should adjust your code as soon as possible. This version also includes a compatibility layer that allows calling them in the old location but that layer will be removed in 2.14.0. **PostgreSQL 12 support removal announcement** Following the deprecation announcement for PostgreSQL 12 in TimescaleDB 2.10, PostgreSQL 12 is not supported starting with TimescaleDB 2.12. Currently supported PostgreSQL major versions are 13, 14 and 15. PostgreSQL 16 support will be added with a following TimescaleDB release. **Features** * #5137 Insert into index during chunk compression * #5150 MERGE support on hypertables * #5515 Make hypertables support replica identity * #5586 Index scan support during UPDATE/DELETE on compressed hypertables * #5596 Support for partial aggregations at chunk level * #5599 Enable ChunkAppend for partially compressed chunks * #5655 Improve the number of parallel workers for decompression * #5758 Enable altering job schedule type through `alter_job` * #5805 Make logrepl markers for (partial) decompressions * #5809 Relax invalidation threshold table-level lock to row-level when refreshing a Continuous Aggregate * #5839 Support CAgg names in chunk_detailed_size * #5852 Make set_chunk_time_interval CAggs aware * #5868 Allow ALTER TABLE ... REPLICA IDENTITY (FULL|INDEX) on materialized hypertables (continuous aggregates) * #5875 Add job exit status and runtime to log * #5909 CREATE INDEX ONLY ON hypertable creates index on chunks **Bugfixes** * #5860 Fix interval calculation for hierarchical CAggs * #5894 Check unique indexes when enabling compression * #5951 _timescaledb_internal.create_compressed_chunk doesn't account for existing uncompressed rows * #5988 Move functions to _timescaledb_functions schema * #5788 Chunk_create must add an existing table or fail * #5872 Fix duplicates on partially compressed chunk reads * #5918 Fix crash in COPY from program returning error * #5990 Place data in first/last function in correct mctx * #5991 Call eq_func correctly in time_bucket_gapfill * #6015 Correct row count in EXPLAIN ANALYZE INSERT .. ON CONFLICT output * #6035 Fix server crash on UPDATE of compressed chunk * #6044 Fix server crash when using duplicate segmentby column * #6045 Fix segfault in set_integer_now_func * #6053 Fix approximate_row_count for CAggs * #6081 Improve compressed DML datatype handling * #6084 Propagate parameter changes to decompress child nodes **Thanks** * @ajcanterbury for reporting a problem with lateral joins on compressed chunks * @alexanderlaw for reporting multiple server crashes * @lukaskirner for reporting a bug with monthly continuous aggregates * @mrksngl for reporting a bug with unusual user names * @willsbit for reporting a crash in time_bucket_gapfill

@ajcanterbury

This release contains performance improvements for compressed hypertables and continuous aggregates and bug fixes since the 2.11.2 release. We recommend that you upgrade at the next available opportunity. This release moves all internal functions from the _timescaleb_internal schema into the _timescaledb_functions schema. This separates code from internal data objects and improves security by allowing more restrictive permissions for the code schema. If you are calling any of those internal functions you should adjust your code as soon as possible. This version also includes a compatibility layer that allows calling them in the old location but that layer will be removed in 2.14.0. **PostgreSQL 12 support removal announcement** Following the deprecation announcement for PostgreSQL 12 in TimescaleDB 2.10, PostgreSQL 12 is not supported starting with TimescaleDB 2.12. Currently supported PostgreSQL major versions are 13, 14 and 15. PostgreSQL 16 support will be added with a following TimescaleDB release. **Features** * #5137 Insert into index during chunk compression * #5150 MERGE support on hypertables * #5515 Make hypertables support replica identity * #5586 Index scan support during UPDATE/DELETE on compressed hypertables * #5596 Support for partial aggregations at chunk level * #5599 Enable ChunkAppend for partially compressed chunks * #5655 Improve the number of parallel workers for decompression * #5758 Enable altering job schedule type through `alter_job` * #5805 Make logrepl markers for (partial) decompressions * #5809 Relax invalidation threshold table-level lock to row-level when refreshing a Continuous Aggregate * #5839 Support CAgg names in chunk_detailed_size * #5852 Make set_chunk_time_interval CAggs aware * #5868 Allow ALTER TABLE ... REPLICA IDENTITY (FULL|INDEX) on materialized hypertables (continuous aggregates) * #5875 Add job exit status and runtime to log * #5909 CREATE INDEX ONLY ON hypertable creates index on chunks **Bugfixes** * #5860 Fix interval calculation for hierarchical CAggs * #5894 Check unique indexes when enabling compression * #5951 _timescaledb_internal.create_compressed_chunk doesn't account for existing uncompressed rows * #5988 Move functions to _timescaledb_functions schema * #5788 Chunk_create must add an existing table or fail * #5872 Fix duplicates on partially compressed chunk reads * #5918 Fix crash in COPY from program returning error * #5990 Place data in first/last function in correct mctx * #5991 Call eq_func correctly in time_bucket_gapfill * #6015 Correct row count in EXPLAIN ANALYZE INSERT .. ON CONFLICT output * #6035 Fix server crash on UPDATE of compressed chunk * #6044 Fix server crash when using duplicate segmentby column * #6045 Fix segfault in set_integer_now_func * #6053 Fix approximate_row_count for CAggs * #6081 Improve compressed DML datatype handling * #6084 Propagate parameter changes to decompress child nodes * #6102 Schedule compression policy more often **Thanks** * @ajcanterbury for reporting a problem with lateral joins on compressed chunks * @alexanderlaw for reporting multiple server crashes * @lukaskirner for reporting a bug with monthly continuous aggregates * @mrksngl for reporting a bug with unusual user names * @willsbit for reporting a crash in time_bucket_gapfill

@ajcanterbury

This release contains performance improvements for compressed hypertables and continuous aggregates and bug fixes since the 2.11.2 release. We recommend that you upgrade at the next available opportunity. This release moves all internal functions from the _timescaleb_internal schema into the _timescaledb_functions schema. This separates code from internal data objects and improves security by allowing more restrictive permissions for the code schema. If you are calling any of those internal functions you should adjust your code as soon as possible. This version also includes a compatibility layer that allows calling them in the old location but that layer will be removed in 2.14.0. **PostgreSQL 12 support removal announcement** Following the deprecation announcement for PostgreSQL 12 in TimescaleDB 2.10, PostgreSQL 12 is not supported starting with TimescaleDB 2.12. Currently supported PostgreSQL major versions are 13, 14 and 15. PostgreSQL 16 support will be added with a following TimescaleDB release. **Features** * #5137 Insert into index during chunk compression * #5150 MERGE support on hypertables * #5515 Make hypertables support replica identity * #5586 Index scan support during UPDATE/DELETE on compressed hypertables * #5596 Support for partial aggregations at chunk level * #5599 Enable ChunkAppend for partially compressed chunks * #5655 Improve the number of parallel workers for decompression * #5758 Enable altering job schedule type through `alter_job` * #5805 Make logrepl markers for (partial) decompressions * #5809 Relax invalidation threshold table-level lock to row-level when refreshing a Continuous Aggregate * #5839 Support CAgg names in chunk_detailed_size * #5852 Make set_chunk_time_interval CAggs aware * #5868 Allow ALTER TABLE ... REPLICA IDENTITY (FULL|INDEX) on materialized hypertables (continuous aggregates) * #5875 Add job exit status and runtime to log * #5909 CREATE INDEX ONLY ON hypertable creates index on chunks **Bugfixes** * #5860 Fix interval calculation for hierarchical CAggs * #5894 Check unique indexes when enabling compression * #5951 _timescaledb_internal.create_compressed_chunk doesn't account for existing uncompressed rows * #5988 Move functions to _timescaledb_functions schema * #5788 Chunk_create must add an existing table or fail * #5872 Fix duplicates on partially compressed chunk reads * #5918 Fix crash in COPY from program returning error * #5990 Place data in first/last function in correct mctx * #5991 Call eq_func correctly in time_bucket_gapfill * #6015 Correct row count in EXPLAIN ANALYZE INSERT .. ON CONFLICT output * #6035 Fix server crash on UPDATE of compressed chunk * #6044 Fix server crash when using duplicate segmentby column * #6045 Fix segfault in set_integer_now_func * #6053 Fix approximate_row_count for CAggs * #6081 Improve compressed DML datatype handling * #6084 Propagate parameter changes to decompress child nodes * #6102 Schedule compression policy more often **Thanks** * @ajcanterbury for reporting a problem with lateral joins on compressed chunks * @alexanderlaw for reporting multiple server crashes * @lukaskirner for reporting a bug with monthly continuous aggregates * @mrksngl for reporting a bug with unusual user names * @willsbit for reporting a crash in time_bucket_gapfill

github-actions bot requested review from gayyappan and nikkhils June 21, 2023 09:38

noctarius force-pushed the logical-replication-decompression-markers branch from 5065eeb to 24bbac3 Compare June 21, 2023 09:49

kgyrtkirk approved these changes Jun 23, 2023

View reviewed changes

tsl/src/compression/compression.c Outdated Show resolved Hide resolved

tsl/src/compression/compression.c Outdated Show resolved Hide resolved

tsl/src/compression/compression.c Show resolved Hide resolved

noctarius force-pushed the logical-replication-decompression-markers branch from 24bbac3 to b00b5dd Compare June 25, 2023 12:22

fabriziomello reviewed Jun 26, 2023

View reviewed changes

tsl/src/compression/compression.c Outdated Show resolved Hide resolved

noctarius force-pushed the logical-replication-decompression-markers branch 2 times, most recently from 5af7c47 to 819a0ce Compare June 26, 2023 14:14

noctarius force-pushed the logical-replication-decompression-markers branch from 793d62c to 6569306 Compare June 29, 2023 13:56

noctarius force-pushed the logical-replication-decompression-markers branch 7 times, most recently from 1ed5d44 to 00fa0dc Compare June 29, 2023 15:38

noctarius force-pushed the logical-replication-decompression-markers branch from 00fa0dc to 6386b72 Compare July 3, 2023 08:37

noctarius force-pushed the logical-replication-decompression-markers branch 3 times, most recently from fc94017 to efe1e69 Compare July 3, 2023 11:11

fabriziomello self-assigned this Jul 10, 2023

fabriziomello assigned noctarius and unassigned fabriziomello Jul 10, 2023

kgyrtkirk reviewed Jul 11, 2023

View reviewed changes

tsl/src/compression/compression.c Outdated Show resolved Hide resolved

noctarius force-pushed the logical-replication-decompression-markers branch 2 times, most recently from 0220d2d to 6ed97e6 Compare July 12, 2023 15:27

fabriziomello approved these changes Aug 8, 2023

View reviewed changes

noctarius requested a review from kgyrtkirk August 8, 2023 13:32

noctarius force-pushed the logical-replication-decompression-markers branch from 6ed97e6 to 0ca4a10 Compare August 8, 2023 13:33

noctarius force-pushed the logical-replication-decompression-markers branch from 0ca4a10 to 68b2492 Compare August 8, 2023 17:18

nikkhils approved these changes Aug 9, 2023

View reviewed changes

antekresic approved these changes Aug 9, 2023

View reviewed changes

noctarius merged commit b5b46a3 into timescale:main Aug 9, 2023
34 of 35 checks passed

noctarius deleted the logical-replication-decompression-markers branch August 9, 2023 11:29

svenklemm mentioned this pull request Sep 20, 2023

Release 2.12.0 #6086

Merged

noctarius mentioned this pull request Sep 25, 2023

Update events are missing the "before" in payload noctarius/timescaledb-event-streamer#70

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make logrepl markers for (partial) decompressions #5805

Make logrepl markers for (partial) decompressions #5805

noctarius commented Jun 21, 2023

github-actions bot commented Jun 21, 2023

codecov bot commented Jun 21, 2023 •

edited

kgyrtkirk left a comment

noctarius commented Jun 25, 2023

fabriziomello left a comment

noctarius commented Jun 26, 2023 •

edited

noctarius commented Jun 26, 2023

noctarius commented Jun 29, 2023

noctarius commented Jun 30, 2023

noctarius commented Jul 3, 2023 •

edited

noctarius commented Jul 20, 2023

fabriziomello commented Jul 21, 2023

noctarius commented Jul 21, 2023

noctarius commented Aug 1, 2023

nikkhils left a comment

Make logrepl markers for (partial) decompressions #5805

Make logrepl markers for (partial) decompressions #5805

Conversation

noctarius commented Jun 21, 2023

github-actions bot commented Jun 21, 2023

codecov bot commented Jun 21, 2023 • edited

Codecov Report

kgyrtkirk left a comment

Choose a reason for hiding this comment

noctarius commented Jun 25, 2023

fabriziomello left a comment

Choose a reason for hiding this comment

noctarius commented Jun 26, 2023 • edited

noctarius commented Jun 26, 2023

noctarius commented Jun 29, 2023

noctarius commented Jun 30, 2023

noctarius commented Jul 3, 2023 • edited

noctarius commented Jul 20, 2023

fabriziomello commented Jul 21, 2023

noctarius commented Jul 21, 2023

noctarius commented Aug 1, 2023

nikkhils left a comment

Choose a reason for hiding this comment

codecov bot commented Jun 21, 2023 •

edited

noctarius commented Jun 26, 2023 •

edited

noctarius commented Jul 3, 2023 •

edited