Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Error enabling compression on hypertable with unique expression index #6205

Closed
konskov opened this issue Oct 17, 2023 · 0 comments · Fixed by #6222
Closed

[Bug]: Error enabling compression on hypertable with unique expression index #6205

konskov opened this issue Oct 17, 2023 · 0 comments · Fixed by #6222
Labels
bug compression

Comments

@konskov
Copy link
Contributor

konskov commented Oct 17, 2023

What type of bug is this?

Unexpected error

What subsystems and features are affected?

Compression

What happened?

alter table mytab set (timescaledb.compress);
ERROR:  XX000: cache lookup failed for attribute 0 of relation 25410

TimescaleDB version affected

2.12.0 and above

PostgreSQL version used

15.2

What operating system did you use?

MacOS Sonoma 14.0

What installation method did you use?

Source

What platform did you run on?

On prem/Self-hosted

Relevant log output and stack trace

No response

How can we reproduce the bug?

create table mytab (col1 varchar(100) not null, col2 integer not null,
value double precision not null default 0, arrival_ts timestamptz not null, departure_ts timestamptz not null
default current_timestamp);

select create_hypertable('mytab', 'departure_ts');
create unique index myidx_unique ON
mytab (lower(col1::text), col2, departure_ts, arrival_ts);
alter table mytab set (timescaledb.compress);
konskov added a commit to konskov/timescaledb that referenced this issue Oct 18, 2023
@konskov
Skip expression columns when verifying index for compression
2634bc4 
Fixes timescale#6205
@konskov konskov mentioned this issue Oct 18, 2023
Closed
konskov added a commit to konskov/timescaledb that referenced this issue Oct 18, 2023
@konskov
Skip expression columns when validating index for compression
ef3ad47 
When enabling compression on a hypertable, we check the unique indexes
defined on it to provide performance improvement hints in case the
unique index columns are not specified as segmentby columns as well.
However this check threw an error when expression columns were present
in the index, preventing the user from enabling compression.
This patch fixes this by simply ignoring the expression columns in the
index, since we cannot currently segment by an expression.

Fixes timescale#6205
konskov added a commit to konskov/timescaledb that referenced this issue Oct 20, 2023
@konskov
Skip expression columns when validating index for compression
2df055c 
When enabling compression on a hypertable, we check the unique indexes
defined on it to provide performance improvement hints in case the
unique index columns are not specified as segmentby columns as well.
However this check threw an error when expression columns were present
in the index, preventing the user from enabling compression.
This patch fixes this by simply ignoring the expression columns in the
index, since we cannot currently segment by an expression.

Fixes timescale#6205
@konskov konskov mentioned this issue Oct 20, 2023
Merged
konskov added a commit to konskov/timescaledb that referenced this issue Oct 20, 2023
@konskov
Fix index inserts during decompression
2bb7b3b 
Since version 2.11.0 we would get a segmentation fault during
decompression when there was an expressional or partial index on the
uncompressed chunk.
This patch fixes this by calling ExecInsertIndexTuples to insert into
indexes during chunk decompression, instead of CatalogIndexInsert.

In addition, when enabling compression on a hypertable, we check the
unique indexes defined on it to provide performance improvement hints
in case the unique index columns are not specified as compression
parameters.
However this check threw an error when expression columns were present
in the index, preventing the user from enabling compression.
This patch fixes this by simply ignoring the expression columns in the
index, since we cannot currently segment by an expression.

Fixes timescale#6205, timescale#6186
konskov added a commit to konskov/timescaledb that referenced this issue Oct 23, 2023
@konskov
Fix index inserts during decompression
c85ae21 
Since version 2.11.0 we would get a segmentation fault during
decompression when there was an expressional or partial index on the
uncompressed chunk.
This patch fixes this by calling ExecInsertIndexTuples to insert into
indexes during chunk decompression, instead of CatalogIndexInsert.

In addition, when enabling compression on a hypertable, we check the
unique indexes defined on it to provide performance improvement hints
in case the unique index columns are not specified as compression
parameters.
However this check threw an error when expression columns were present
in the index, preventing the user from enabling compression.
This patch fixes this by simply ignoring the expression columns in the
index, since we cannot currently segment by an expression.

Fixes timescale#6205, timescale#6186
konskov added a commit to konskov/timescaledb that referenced this issue Oct 23, 2023
@konskov
Fix index inserts during decompression
3342cbb 
Since version 2.11.0 we would get a segmentation fault during
decompression when there was an expressional or partial index on the
uncompressed chunk.
This patch fixes this by calling ExecInsertIndexTuples to insert into
indexes during chunk decompression, instead of CatalogIndexInsert.

In addition, when enabling compression on a hypertable, we check the
unique indexes defined on it to provide performance improvement hints
in case the unique index columns are not specified as compression
parameters.
However this check threw an error when expression columns were present
in the index, preventing the user from enabling compression.
This patch fixes this by simply ignoring the expression columns in the
index, since we cannot currently segment by an expression.

Fixes timescale#6205, timescale#6186
konskov added a commit to konskov/timescaledb that referenced this issue Oct 24, 2023
@konskov
Fix index inserts during decompression
708c392 
Since version 2.11.0 we would get a segmentation fault during
decompression when there was an expressional or partial index on the
uncompressed chunk.
This patch fixes this by calling ExecInsertIndexTuples to insert into
indexes during chunk decompression, instead of CatalogIndexInsert.

In addition, when enabling compression on a hypertable, we check the
unique indexes defined on it to provide performance improvement hints
in case the unique index columns are not specified as compression
parameters.
However this check threw an error when expression columns were present
in the index, preventing the user from enabling compression.
This patch fixes this by simply ignoring the expression columns in the
index, since we cannot currently segment by an expression.

Fixes timescale#6205, timescale#6186
konskov added a commit that referenced this issue Oct 24, 2023
@konskov
Fix index inserts during decompression
7b7722e 
Since version 2.11.0 we would get a segmentation fault during
decompression when there was an expressional or partial index on the
uncompressed chunk.
This patch fixes this by calling ExecInsertIndexTuples to insert into
indexes during chunk decompression, instead of CatalogIndexInsert.

In addition, when enabling compression on a hypertable, we check the
unique indexes defined on it to provide performance improvement hints
in case the unique index columns are not specified as compression
parameters.
However this check threw an error when expression columns were present
in the index, preventing the user from enabling compression.
This patch fixes this by simply ignoring the expression columns in the
index, since we cannot currently segment by an expression.

Fixes #6205, #6186
jnidzwetzki pushed a commit to jnidzwetzki/timescaledb that referenced this issue Nov 9, 2023
@konskov @jnidzwetzki
Fix index inserts during decompression
41dde98 
Since version 2.11.0 we would get a segmentation fault during
decompression when there was an expressional or partial index on the
uncompressed chunk.
This patch fixes this by calling ExecInsertIndexTuples to insert into
indexes during chunk decompression, instead of CatalogIndexInsert.

In addition, when enabling compression on a hypertable, we check the
unique indexes defined on it to provide performance improvement hints
in case the unique index columns are not specified as compression
parameters.
However this check threw an error when expression columns were present
in the index, preventing the user from enabling compression.
This patch fixes this by simply ignoring the expression columns in the
index, since we cannot currently segment by an expression.

Fixes timescale#6205, timescale#6186
jnidzwetzki pushed a commit to jnidzwetzki/timescaledb that referenced this issue Nov 19, 2023
@konskov @jnidzwetzki
Fix index inserts during decompression
05e74e8 
Since version 2.11.0 we would get a segmentation fault during
decompression when there was an expressional or partial index on the
uncompressed chunk.
This patch fixes this by calling ExecInsertIndexTuples to insert into
indexes during chunk decompression, instead of CatalogIndexInsert.

In addition, when enabling compression on a hypertable, we check the
unique indexes defined on it to provide performance improvement hints
in case the unique index columns are not specified as compression
parameters.
However this check threw an error when expression columns were present
in the index, preventing the user from enabling compression.
This patch fixes this by simply ignoring the expression columns in the
index, since we cannot currently segment by an expression.

Fixes timescale#6205, timescale#6186
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug compression
Projects
None yet
Milestone
No milestone
1 participant
@konskov