Fix wrong use of Const instead of Datum

[konskov]

PG16 converted the GetDatum() and DatumGet() macros to inline
functions. This enabled the compiler to catch a wrong use of Const
instead of Datum.

postgres/postgres@c8b2ef0

(regression introduced by #6203)

[github-actions]

@mkindahl, @antekresic: please review this pull request.

Powered by pull-review

[mkindahl]

Looks good, but one question.

[codecov]

Codecov Report

Merging #6269 (a957fb8) into main (c58a640) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #6269      +/-   ##
==========================================
- Coverage   65.30%   65.27%   -0.03%     
==========================================
  Files         247      247              
  Lines       57528    57482      -46     
  Branches    12784    12765      -19     
==========================================
- Hits        37569    37524      -45     
- Misses      18073    18084      +11     
+ Partials     1886     1874      -12     

Files	Coverage Δ
tsl/src/nodes/decompress_chunk/exec.c	92.93% <0.00%> (ø)

... and 68 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

[akuzm]

Oh, I just broke it today, thanks for the fix :) It's hard to add the test for this particular condition until we have vectorized scalar array operations. I'll add it at that time.

[konskov]

Thank you for explaining @fabriziomello , I've updated the commit message

[fabriziomello]

Oh, I just broke it today, thanks for the fix :) It's hard to add the test for this particular condition until we have vectorized scalar array operations. I'll add it at that time.

Don't worry ... We're almost there for enabling PG16 on CI (we just merged some last failures today)