Don't try to compress osm chunks #6670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antekresic
approved these changes
Feb 17, 2024
src/chunk.c
Outdated
| { | ||
| if (throw_error) | ||
| elog(ERROR, | ||
| "%s not permitted on osm chunk \"%s\" ", |
There was a problem hiding this comment.
OSM chunk can sound confusing to end users, should the error say tiered chunk?
fabriziomello
approved these changes
Feb 17, 2024
svenklemm
force-pushed
the
osm_chunk
branch
3 times, most recently
from
865c844
to
63afbf2
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6670 +/- ##
==========================================
+ Coverage 80.06% 81.46% +1.39%
==========================================
Files 190 190
Lines 37181 36392 -789
Branches 9450 9459 +9
==========================================
- Hits 29770 29647 -123
+ Misses 2997 2983 -14
+ Partials 4414 3762 -652 ☔ View full report in Codecov by Sentry. |
This patch filters out the osm chunk in the compression policy and adds some additional checks so we dont run compress_chunk on osm chunks.
svenklemm
added a commit
to svenklemm/timescaledb
that referenced
this pull request
Feb 19, 2024
This release contains bug fixes since the 2.14.1 release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * timescale#6655 Fix segfault in cagg_validate_query * timescale#6660 Fix refresh on empty CAgg with variable bucket * timescale#6670 Don't try to compress osm chunks **Thanks** * @kav23alex for reporting a segfault in cagg_validate_query
svenklemm
added a commit
that referenced
this pull request
Feb 20, 2024
This release contains bug fixes since the 2.14.1 release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * #6655 Fix segfault in cagg_validate_query * #6660 Fix refresh on empty CAgg with variable bucket * #6670 Don't try to compress osm chunks **Thanks** * @kav23alex for reporting a segfault in cagg_validate_query
svenklemm
added a commit
that referenced
this pull request
Feb 20, 2024
This release contains bug fixes since the 2.14.1 release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * #6655 Fix segfault in cagg_validate_query * #6660 Fix refresh on empty CAgg with variable bucket * #6670 Don't try to compress osm chunks **Thanks** * @kav23alex for reporting a segfault in cagg_validate_query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch filters out the osm chunk in the compression policy and adds some additional checks so we dont run compress_chunk on osm chunks.