Fully recompress unordered compressed chunks #6774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6774 +/- ##
==========================================
+ Coverage 80.06% 80.72% +0.65%
==========================================
Files 190 191 +1
Lines 37181 36415 -766
Branches 9450 9496 +46
==========================================
- Hits 29770 29395 -375
- Misses 2997 3168 +171
+ Partials 4414 3852 -562 ☔ View full report in Codecov by Sentry. |
antekresic
force-pushed
the
fix-rollup
branch
3 times, most recently
from
f64ff86
to
17b0c81
Compare
svenklemm
approved these changes
Mar 15, 2024
akuzm
approved these changes
Mar 18, 2024
Recent changes switched recompression of unordered compressed chunks to use segmentwise recompression which is designed to work with partial chunks only. This change reverts that back to full recompression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes switched recompression of unordered compressed chunks to use segmentwise recompression which is designed to work with partial chunks only. This change reverts that back to full recompression.
Disable-check: force-changelog-file