Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missed changelog message for COPY segfault fix #6947

Merged
merged 1 commit into from
May 23, 2024

Conversation

akuzm
Copy link
Member

@akuzm akuzm commented May 23, 2024

We didn't have changelog check in the required ones, I added it now.

Fixes #6540

We didn't have changelog check in the required ones, I added it now.
@akuzm akuzm added the force-auto-backport Automatically backport this PR or fix of this issue, even if it's not marked as "bug" label May 23, 2024
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.70%. Comparing base (59f50f2) to head (7d6cd18).
Report is 174 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6947      +/-   ##
==========================================
+ Coverage   80.06%   81.70%   +1.63%     
==========================================
  Files         190      198       +8     
  Lines       37181    36851     -330     
  Branches     9450     9632     +182     
==========================================
+ Hits        29770    30110     +340     
+ Misses       2997     2866     -131     
+ Partials     4414     3875     -539     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@antekresic antekresic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did this pass CI? Did we remove the requirement for changelog entries?

Copy link
Member

@svenklemm svenklemm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svenklemm
Copy link
Member

How did this pass CI? Did we remove the requirement for changelog entries?

It's not required atm not sure when it was turned off.

@akuzm
Copy link
Member Author

akuzm commented May 23, 2024

How did this pass CI? Did we remove the requirement for changelog entries?

Yeah, for some reason the check was not in the required checks, I added it back in the branch protection settings https://github.com/timescale/timescaledb/settings/branch_protection_rules/799421

@akuzm akuzm merged commit f5d466c into timescale:main May 23, 2024
38 of 40 checks passed
@akuzm akuzm deleted the changelog branch May 23, 2024 17:04
github-actions bot pushed a commit that referenced this pull request May 23, 2024
We didn't have changelog check in the required ones, I added it now.

(cherry picked from commit f5d466c)
timescale-automation pushed a commit that referenced this pull request May 23, 2024
We didn't have changelog check in the required ones, I added it now.

(cherry picked from commit f5d466c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported-2.15.x force-auto-backport Automatically backport this PR or fix of this issue, even if it's not marked as "bug"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Timescale segfaults when backfilling data
4 participants