-
Notifications
You must be signed in to change notification settings - Fork 852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missed changelog message for COPY segfault fix #6947
Conversation
We didn't have changelog check in the required ones, I added it now.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6947 +/- ##
==========================================
+ Coverage 80.06% 81.70% +1.63%
==========================================
Files 190 198 +8
Lines 37181 36851 -330
Branches 9450 9632 +182
==========================================
+ Hits 29770 30110 +340
+ Misses 2997 2866 -131
+ Partials 4414 3875 -539 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did this pass CI? Did we remove the requirement for changelog entries?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It's not required atm not sure when it was turned off. |
Yeah, for some reason the check was not in the required checks, I added it back in the branch protection settings https://github.com/timescale/timescaledb/settings/branch_protection_rules/799421 |
We didn't have changelog check in the required ones, I added it now. (cherry picked from commit f5d466c)
We didn't have changelog check in the required ones, I added it now. (cherry picked from commit f5d466c)
We didn't have changelog check in the required ones, I added it now.
Fixes #6540