Prevent locking compressed tuples #7046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7046 +/- ##
==========================================
+ Coverage 80.06% 81.80% +1.73%
==========================================
Files 190 200 +10
Lines 37181 37232 +51
Branches 9450 9702 +252
==========================================
+ Hits 29770 30456 +686
+ Misses 2997 2876 -121
+ Partials 4414 3900 -514 ☔ View full report in Codecov by Sentry. |
antekresic
approved these changes
Jun 19, 2024
akuzm
reviewed
Jun 19, 2024
akuzm
approved these changes
Jun 19, 2024
svenklemm
force-pushed
the
lock_compressed
branch
3 times, most recently
from
f876a74
to
939f0f3
Compare
Error out when we detect that a scan is trying to lock compressed tuple. This does not block lock tuples on compressed hypertables in general but only errors for queries where actual compressed tuples would be returned. This will allow queries on compressed hypertables where compressed tuples are filtered by other means e.g. chunk exclusion or query constraints. Not blocking this will produce a very misleading `Could not read block 0` error.
svenklemm
force-pushed
the
lock_compressed
branch
from
939f0f3
to
d101adc
Compare
pallavisontakke
added a commit
to pallavisontakke/timescaledb
that referenced
this pull request
Jul 18, 2024
This release contains performance improvements and bug fixes since the 2.15.3 release. We recommend that you upgrade at the next available opportunity. **Features** * timescale#6880: Add support for the array operators used for compressed DML batch filtering. * timescale#6895: Improve the compressed DML expression pushdown. * timescale#6897: Add support for replica identity on compressed hypertables. * timescale#6918: Remove support for PG13. * timescale#6920: Rework compression activity wal markers. * timescale#6989: Add support for foreign keys when converting plain tables to hypertables. * timescale#7020: Add support for the chunk column statistics tracking. * timescale#7048: Add an index scan for INSERT DML decompression. * timescale#7075: Reduce decompression on the compressed INSERT. * timescale#7101: Reduce decompressions for the compressed UPDATE/DELETE. * timescale#7108 Reduce decompressions for INSERTs with UNIQUE constraints **Bugfixes** * timescale#7018: Fix `search_path` quoting in the compression defaults function. * timescale#7046: Prevent locking for compressed tuples. * timescale#7055: Fix the `scankey` for `segment by` columns, where the type `constant` is different to `variable`. * timescale#7064: Fix the bug in the default `order by` calculation in compression. * timescale#7069: Fix the index column name usage. * timescale#7074: Fix the bug in the default `segment by` calculation in compression. **Thanks**
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error out when we detect that a scan is trying to lock compressed tuple. This does not block lock tuples on compressed hypertables in general but only errors for queries where actual compressed tuples would be returned. This will allow queries on compressed hypertables where compressed tuples are filtered by other means e.g. chunk exclusion or query constraints.
Not blocking this will produce a very misleading
Could not read block 0error.