Handle NULL as attstattarget default value in PG17 #7105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenklemm
force-pushed
the
pg17_attstattarget_nullable
branch
from
6063c1d
to
591d792
Compare
antekresic
approved these changes
Jul 6, 2024
fabriziomello
approved these changes
Jul 6, 2024
svenklemm
force-pushed
the
pg17_attstattarget_nullable
branch
from
591d792
to
ee45175
Compare
PG17 changed attstattarget to be NULLABLE and changed the default to NULL. This patch changes the pg_attribute to produce the same result against PG17 and previous versions. postgres/postgres@4f62250
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7105 +/- ##
==========================================
+ Coverage 80.06% 81.78% +1.71%
==========================================
Files 190 202 +12
Lines 37181 37396 +215
Branches 9450 9760 +310
==========================================
+ Hits 29770 30583 +813
+ Misses 2997 2893 -104
+ Partials 4414 3920 -494 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PG17 changed attstattarget to be NULLABLE and changed the default to NULL. This patch changes the pg_attribute to produce the same result against PG17 and previous versions.
postgres/postgres@4f62250
Disable-check: commit-count
Disable-check: force-changelog-file