Skip to content

Commit

Permalink
changes from review comments
Browse files Browse the repository at this point in the history
Signed-off-by: Vineeth Pothulapati <vineethpothulapati@outlook.com>
  • Loading branch information
VineethReddy02 committed Nov 18, 2020
1 parent 5bdc132 commit e6eea67
Show file tree
Hide file tree
Showing 6 changed files with 2 additions and 30 deletions.
2 changes: 1 addition & 1 deletion cli/README.md
Expand Up @@ -121,4 +121,4 @@ Then, move the `tobs` binary from the current directory to your `/bin` folder.

__Dependencies__: [kubectl](https://kubernetes.io/docs/tasks/tools/install-kubectl/), [kind](https://kind.sigs.k8s.io/)

A testing suite is included in the `tests` folder. The testing suite can be run by `./e2e-tests.sh` this script will create kind cluster executes the test suite and deletes the kind cluster.
A testing suite is included in the `tests` folder. The testing suite can be run by `./e2e-tests.sh` this script will create a [kind](https://kind.sigs.k8s.io) cluster, execute the test suite, and delete the kind cluster.
6 changes: 1 addition & 5 deletions cli/tests/concurrent_test.go
Expand Up @@ -31,11 +31,7 @@ func TestConcurrent(t *testing.T) {
}

// skipping concurrent tests for now
// as this needs some work re-writing the concurrent tests
// adding just an return will fail go vet check so wrapping it into if block.
if true {
return
}
t.Skip("Skipping concurrent tests as it needs changes on multiple tobs installations on the same cluster.")

testUninstall(t, "", "", false)

Expand Down
6 changes: 0 additions & 6 deletions cli/tests/testdata/f1.yml
Expand Up @@ -42,12 +42,6 @@ promscale:
# will get created
loadBalancer:
enabled: false
resources:
requests:
# By default this should be enough for a cluster
# with only a few pods
#memory: 2Gi
#cpu: 1
# Values for configuring the deployment of Prometheus
# The stable/prometheus chart is used and the guide for it
# can be found at:
Expand Down
6 changes: 0 additions & 6 deletions cli/tests/testdata/f2.yml
Expand Up @@ -42,12 +42,6 @@ promscale:
# will get created
loadBalancer:
enabled: false
resources:
requests:
# By default this should be enough for a cluster
# with only a few pods
#memory: 2Gi
#cpu: 1
# Values for configuring the deployment of Prometheus
# The stable/prometheus chart is used and the guide for it
# can be found at:
Expand Down
6 changes: 0 additions & 6 deletions cli/tests/testdata/f3.yml
Expand Up @@ -42,12 +42,6 @@ promscale:
# will get created
loadBalancer:
enabled: false
resources:
requests:
# By default this should be enough for a cluster
# with only a few pods
#memory: 4Gi
#cpu: 2
# Values for configuring the deployment of Prometheus
# The stable/prometheus chart is used and the guide for it
# can be found at:
Expand Down
6 changes: 0 additions & 6 deletions cli/tests/testdata/f4.yml
Expand Up @@ -42,12 +42,6 @@ promscale:
# will get created
loadBalancer:
enabled: false
resources:
requests:
# By default this should be enough for a cluster
# with only a few pods
#memory: 4Gi
#cpu: 1
# Values for configuring the deployment of Prometheus
# The stable/prometheus chart is used and the guide for it
# can be found at:
Expand Down

0 comments on commit e6eea67

Please sign in to comment.