Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not shell out in tests #279

Closed
paulfantom opened this issue Mar 2, 2022 · 1 comment
Closed

Do not shell out in tests #279

paulfantom opened this issue Mar 2, 2022 · 1 comment
Labels
enhancement Improvement of an existing feature good first issue Good for newcomers help wanted Extra attention is needed

Comments

@paulfantom
Copy link
Contributor

Currently tests for tobs are written by shelling out and using kubectl binary. This is hard to debug and requires parsing strings. Instead we should be using kubernetes client-go library.
@paulfantom paulfantom added the cli label Mar 2, 2022
@paulfantom paulfantom mentioned this issue Mar 2, 2022
Merged
This was referenced Apr 28, 2022
Closed
Closed
@paulfantom paulfantom added good first issue Good for newcomers help wanted Extra attention is needed labels Apr 28, 2022
@paulfantom paulfantom added the enhancement Improvement of an existing feature label May 9, 2022
@paulfantom
Copy link
Contributor Author

We are rewriting test framework. More on that can be tracked in #417 and #408

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement of an existing feature good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@paulfantom