cli: bump and fix otel-operator dependency #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesGuthrie
approved these changes
Feb 24, 2022
antekresic
approved these changes
Feb 24, 2022
sumerman
approved these changes
Feb 24, 2022
jgpruitt
approved these changes
Feb 24, 2022
|
Potentially blocked by #273 |
paulfantom
force-pushed
the
cli-otel
branch
2 times, most recently
from
e890845
to
62c8614
Compare
|
PInning to earliest opentelemetry-operator version that has This should limit number of updates done in the PR and allow easier debugging of issues with e2e tests. My current diagnosis is that newer kubernetes library changed something in how port-forwarding logic works (maybe layout changed or something) and thus tests are failing. This is related to #279. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fixing incorrect dependency
github.com/open-telemetry/opentelemetry-operator/api/v1alpha1togithub.com/open-telemetry/opentelemetry-operator/apis/v1alpha1(noticesin/apis/).Additionally
go mod tidywas run to update some dependencies and clean up go.mod file.