Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed timescaledb loader initialization #255

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed timescaledb loader initialization #255

wants to merge 1 commit into from

Conversation

Koheiru
Copy link

@Koheiru Koheiru commented Jun 6, 2024

At some point timescaledb's function create_hypertable became more strict and it starts to fail if 'replication_factor => NULL' part exists. In such case tsbs_load failed with error:

could not execute sql: SELECT create_hypertable('disk'::regclass, 'time'::name, replication_factor => NULL, chunk_time_interval => 43200000000, create_default_indexes=>FALSE)panic: ERROR: function create_hypertable(regclass, name, replication_factor => unknown, chunk_time_interval => bigint, create_default_indexes => boolean) does not exist (SQLSTATE 42883)

Other users also report about this issue: #248

To fix this issue timescaledb table initialization method was adjusted.

@Koheiru
Fixed timescaledb loader initialization
7e04e20 
At some point timescaledb's function  became more strict,
so it failed if 'replication_factor => NULL' part exists.
Table initialization method was refactored to fix this
issue.

Signed-off-by: Koheiru <prosto_yurik@mail.ru>
@Koheiru Koheiru mentioned this pull request Jun 6, 2024
Open
@tomchon
Copy link

tomchon commented Jun 26, 2024

has anyone merged this fix into the master branch? @Koheiru

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Koheiru @tomchon