Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added yarn lockfile #22

Merged
merged 1 commit into from
Mar 25, 2017
Merged

added yarn lockfile #22

merged 1 commit into from
Mar 25, 2017

Conversation

jordaaash
Copy link
Contributor

yarn is an npm client that allows versions of dependencies to be locked down and prevents breaks due to changes in dependencies (and most nefariously, dependencies of dependencies). Even using exact versioning doesn't fix the latter case, but yarn does, and is faster and easier than using npm shrinkwrap.

This commit adds a yarn.lock file (generated with yarn install), which allows this library to be cloned and installed with yarn install --pure-lockfile to guarantee that the dependencies match what's being used in tests. This is especially useful when installing PgBoss in production (which we are working on doing!)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 94dacce on jordansexton:yarn into 3c39ecc on timgit:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 94dacce on jordansexton:yarn into 3c39ecc on timgit:master.

@timgit
Copy link
Owner

timgit commented Mar 24, 2017

weird. The last PR I did for 0.5.1 blew away the yarn lock file I had in 0.5.0. Didn't realize it was missing until now. Thanks!

@jordaaash
Copy link
Contributor Author

Oh, cool. I didn't check the history, sorry!

@timgit
Copy link
Owner

timgit commented Mar 24, 2017

btw, did you run into a dependency issue that prompted this?

@jordaaash
Copy link
Contributor Author

No, I was just building from source to poke around and saw there was no yarn lockfile.

@timgit
Copy link
Owner

timgit commented Mar 24, 2017

ok. Just confirming it was a dev-time and not run-time concern with the published package

@timgit timgit merged commit 8337a16 into timgit:master Mar 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants