Prevent node from dying when DB unavailable by wrapping getMaintenanceTime
#374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note, with this fix in place, what would normally cause node to die in a few minutes (via this test project) has been running for over 30min just fine. I will leave it running for several hours just to be sure there are no other periodic tasks that may cause issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @timgit!
I was doing some testing on the latest release (thanks again for that BTW!) before bumping our version in Wasp and noticed if I killed the DB I could still get an error that took down node. It appears the issue is there was a call in
Boss.metaMonitortoBoss.getMaintenanceTimethat was not wrapped like some of the others and will blow up if no DB is available.This small PR just wraps it the function that calls it. If you would like me to add any tests like the others, or make any other tweaks, I can as well. 馃憤馃徎
Thanks!
Shayne