Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add work overloads fix batchSize typing #402

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

nomocas
Copy link
Contributor

@nomocas nomocas commented Jun 19, 2023

Closes #401

@nomocas
Copy link
Contributor Author

nomocas commented Jun 20, 2023

Hi again,

The fail is weird regarding the commited change, which is just about the typing that is not used in any test, as all tests are pure JS.

Also, the test that is failing is not related to batchSize. (But whatever, as said above, the typing has nothing to do with the tests)

Build error:

retries
       should retry with a exponential backoff:
      AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:

Of course, when I launch all the tests locally, no error.

Any idea ?

@timgit timgit merged commit 2a33d33 into timgit:master Jun 22, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript typing issue with work and batchSize
2 participants