Skip to content
This repository has been archived by the owner on Feb 9, 2020. It is now read-only.

v0.4 tuple vararg syntax #59

Merged
merged 1 commit into from Apr 22, 2015
Merged

v0.4 tuple vararg syntax #59

merged 1 commit into from Apr 22, 2015

Conversation

sebastiang
Copy link
Contributor

I'm not clear on whether the new Tuple{Vararg{T}} syntax is locked down, but this change at least gets Grid to compile and pass tests. I have to admit I'm not a fan of the Vararg, preferring ellipses, but I know that's been bike-shedded around extensively elsewhere.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.26% when pulling 5f75a3c on PalladiumConsulting:sg/tuple into e1a6209 on timholy:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.26% when pulling 5f75a3c on PalladiumConsulting:sg/tuple into e1a6209 on timholy:master.

@tomasaschan
Copy link
Collaborator

LGTM; I'm not a big fan of the syntax either, but we might as well stick with whatever is in Base for now, and then update again if the syntax changes. It might not, after all :)

@timholy
Copy link
Owner

timholy commented Apr 22, 2015

Thanks for tackling this, @sebastiang!

@sebastiang
Copy link
Contributor Author

updated the botched translate

@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.26% when pulling ef7a235 on PalladiumConsulting:sg/tuple into e1a6209 on timholy:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.26% when pulling ef7a235 on PalladiumConsulting:sg/tuple into e1a6209 on timholy:master.

timholy added a commit that referenced this pull request Apr 22, 2015
@timholy timholy merged commit a1e35c2 into timholy:master Apr 22, 2015
@timholy
Copy link
Owner

timholy commented Apr 22, 2015

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants