Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please support new libhdf5 names in Debian #153

Closed
pini-gh opened this issue Sep 21, 2014 · 4 comments
Closed

Please support new libhdf5 names in Debian #153

pini-gh opened this issue Sep 21, 2014 · 4 comments

Comments

@pini-gh
Copy link
Contributor

pini-gh commented Sep 21, 2014

Hi,

Starting with release 1.8.13, the serial and MPI flavors of libhdf5 are now co-installable in Debian. This is at the cost of renaming the runtime libraries to libhdf5_${flavor}. See the corresponding changelog for release 1.8.13+docs-1: http://metadata.ftp-master.debian.org/changelogs/main/h/hdf5/unstable_changelog

Supporting this change seems as simple as changing line 6 in deps/build.jl from
hdf5 = library_dependency("libhdf5")
to
hdf5 = library_dependency("libhdf5", aliases = ["libhdf5", "libhdf5_serial", "linhdf5_openmpi", "libhdf5_mpich"])

Thanks in advance,

_g.

@timholy
Copy link
Member

timholy commented Sep 21, 2014

FYI pini-gh, for any source file you can just click the pencil icon and edit it. Then submit your changes, it will be tested automatically by Travis & AppVeyor, and if it passes the tests and otherwise seems reasonable I'll merge it. If you want "credit" here, go ahead and do that, otherwise I'll just follow your advice.

@pini-gh
Copy link
Contributor Author

pini-gh commented Sep 21, 2014

Thanks for merging. Do you plan to push a new release into METADATA.jl soonish?

@timholy
Copy link
Member

timholy commented Sep 21, 2014

It was long overdue. Done. Thanks for prompting me.

@timholy timholy closed this as completed Sep 21, 2014
@pini-gh
Copy link
Contributor Author

pini-gh commented Sep 21, 2014

Tim Holy a écrit , Le 21/09/2014 22:45:

It was long overdue. Done. Thanks for prompting me.

Thanks!

_g.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants