Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration of fileio #352

Closed
wants to merge 19 commits into from
Closed

integration of fileio #352

wants to merge 19 commits into from

Conversation

SimonDanisch
Copy link
Member

Just realized there is no PR up for this yet ;)
TODO:

  • port ImageMagick to FileIO
  • port NRRD to FileIO
  • create repo for AndorSIF
  • port OSXNative to FileIO and create tests
  • port Imagine

NRRD.jl and ImageMagick should mostly work over FileIO.
grayim is supposed to return an Array{Gray{X}, N}, right?
also right now, the IO test does fail, as it handles timedims/3d
different then what imagemagick does
SimonDanisch and others added 9 commits September 22, 2015 13:02
NRRD.jl and ImageMagick should mostly work over FileIO.

removed imagemagick, is now in ImageMagick.jl

removed io includes

included latest changes from master and fixed up grayim - maybe

grayim is supposed to return an Array{Gray{X}, N}, right?
also right now, the IO test does fail, as it handles timedims/3d
different then what imagemagick does

precompile should be fine without IO, is it?
NRRD.jl and ImageMagick should mostly work over FileIO.
removed imagemagick, is now in ImageMagick.jl

removed io includes

included latest changes from master and fixed up grayim - maybe

grayim is supposed to return an Array{Gray{X}, N}, right?
also right now, the IO test does fail, as it handles timedims/3d
different then what imagemagick does

precompile should be fine without IO, is it?
This reverts commit 62348524bf8ee1ca8069c59611bb1f928e983247.
Put call to MagickWandGenesis inside __init__ on all platforms
@SimonDanisch
Copy link
Member Author

Oh the writemime stuff is missing.
Any smart ideas how to do this nicely with FileIO?
I've never used MIME types, so I'm not really sure what's needed.

@timholy
Copy link
Member

timholy commented Sep 26, 2015

Wow, this is really exciting!

writemime is IO, so it seems reasonable to have it in FileIO. I think in this case it's fine to just move the functions over to ImageMagick.jl.

NRRD.jl and ImageMagick should mostly work over FileIO.

removed imagemagick, is now in ImageMagick.jl

removed io includes

included latest changes from master and fixed up grayim - maybe

grayim is supposed to return an Array{Gray{X}, N}, right?
also right now, the IO test does fail, as it handles timedims/3d
different then what imagemagick does

precompile should be fine without IO, is it?
NRRD.jl and ImageMagick should mostly work over FileIO.

started rewriting SIF

removed io includes

included latest changes from master and fixed up grayim - maybe

grayim is supposed to return an Array{Gray{X}, N}, right?
also right now, the IO test does fail, as it handles timedims/3d
different then what imagemagick does

precompile should be fine without IO, is it?

started removing files that go into FileIO

NRRD.jl and ImageMagick should mostly work over FileIO.

started rewriting SIF

removed imagemagick, is now in ImageMagick.jl

removed io includes

included latest changes from master and fixed up grayim - maybe

grayim is supposed to return an Array{Gray{X}, N}, right?
also right now, the IO test does fail, as it handles timedims/3d
different then what imagemagick does

precompile should be fine without IO, is it?

Revert "started rewriting SIF"

This reverts commit 62348524bf8ee1ca8069c59611bb1f928e983247.

remove remaining IO parts

remove more IO related files

removed more IO
@SimonDanisch
Copy link
Member Author

see #373

@timholy timholy deleted the sd/fileio branch December 24, 2020 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants