Fix depwarn on 0.6 due to vectorized functions #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Travis linux nightly failure looks new and unrelated. @tkelman in case it's known or worth attention. |
yuyichao
force-pushed
the
yyc/0.6-dep
branch
from
f9cbb52
to
a827283
Compare
yuyichao
force-pushed
the
yyc/0.6-dep
branch
from
a827283
to
031f41f
Compare
yuyichao
changed the title
|
Figured out what's wrong with the test and should be fixed now. Not sure about the libgit2 issue (if it appears again). |
|
Looks great, thanks a bunch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tests passes locally. The WIP is because there's one test that I need to change. The test starts to fail on 0.4 half way when I'm making the changes and I have no idea why it's happening.