Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enabled = false not working in IJulia #214

Closed
saulpila opened this issue Jul 16, 2021 · 3 comments · Fixed by #216
Closed

enabled = false not working in IJulia #214

saulpila opened this issue Jul 16, 2021 · 3 comments · Fixed by #216

Comments

@saulpila
Copy link

I am setting enabled = false but I still get a progress meter. Shouldn't it be | instead of & here?

ProgressMeter.jl/src/ProgressMeter.jl

Line 261 in e1c7c71

(!RUNNING_IJULIA_KERNEL[] & !p.enabled) && return

ProgressMeter.jl/src/ProgressMeter.jl

Line 339 in e1c7c71

(!RUNNING_IJULIA_KERNEL[] & !p.enabled) && return

@IanButterworth
Copy link
Collaborator

IanButterworth commented Jul 17, 2021 •
edited

@jd-lara would you be able to take a look at this given this was introduced in #185?
On reflection, it's not clear to me what the behavior in IJulia (which I assume @saulpila is using) is supposed to be here

@saulpila
Copy link
Author

Yes! This happens in IJulia. Sorry for not specifying.

@IanButterworth IanButterworth changed the title enabled = false not working enabled = false not working in IJulia Jul 17, 2021
@jd-lara
Copy link
Contributor

jd-lara commented Jul 24, 2021

@IanButterworth I can check it out but I don't use IJulia too much

@halleysfifthinc halleysfifthinc mentioned this issue Aug 13, 2021
Merged
goerz added a commit to JuliaQuantumControl/QuantumPropagators.jl that referenced this issue Sep 10, 2021
@goerz
Work around ProgressMeter bug in Jupyter notebook
5f43c3d 
This is a workaround for
timholy/ProgressMeter.jl#214
martinholters pushed a commit that referenced this issue Sep 13, 2021
@halleysfifthinc @martinholters
Remove enabled dependence on IJulia; fix #214
5b74b84 
It doesn't make sense to me that `enabled` stops working (ie Progress will *always* update/print) in IJulia.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove enabled dependence on IJulia; fix #214
3 participants
@IanButterworth @saulpila @jd-lara