New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't round up to 100% if not complete #300

Closed

IanButterworth opened this issue Feb 15, 2024 · 0 comments · Fixed by #301

Collaborator

IanButterworth commented Feb 15, 2024 •

edited

I feel 100% should be reserved for the "finished" state.

julia> p = Progress(1000);

julia> update!(p, 999)
Progress: 100%|███████████████████████████████████████████████████████████████████████████████████▉|  ETA: 0:00:00
julia> update!(p, 1000)
Progress: 100%|████████████████████████████████████████████████████████████████████████████████████| Time: 0:00:13

The text was updated successfully, but these errors were encountered:

MarcMush mentioned this issue

don't round up to 100% if not finished #301

Merged

MarcMush closed this as completed in #301

iajzenszmi mentioned this issue

Some tests did not pass #313

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment