Improve finish!
behavior for Progress
#198
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
finish!
is called on aProgress
type meter with a slow update limit and a significant number of steps left, it will max a CPU core while slowly updating the progress meter until it is complete.MWE:
This took me by surprise, and doesn't match the immediate completion behavior specified in the code for the
finish!
methods forProgressThresh
andProgressUnknown
.PR: