Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overprinting in ProgressUnknown #204

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

palday
Copy link

@palday palday commented May 19, 2021

This just adds in the same logic that's present in ProgressThresh and Progress.

@IanButterworth
Copy link
Collaborator

@palday I don't use IJulia so wouldn't know how to test this, and tests don't cover this.
If you could add some examples of before and after, that would be helpful

@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #204 (fb2963f) into master (aae026e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #204      +/-   ##
==========================================
+ Coverage   96.32%   96.34%   +0.02%     
==========================================
  Files           1        1              
  Lines         490      493       +3     
==========================================
+ Hits          472      475       +3     
  Misses         18       18              
Impacted Files Coverage Δ
src/ProgressMeter.jl 96.34% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aae026e...fb2963f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants