add support for offset in ProgressUnknown #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcMush
force-pushed
the
offsetUnknown
branch
from
ec4e9f2
to
ad6537c
Compare
|
remerged because of non-passing tests, ready to merge if it passes now |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #217 +/- ##
==========================================
+ Coverage 96.56% 96.61% +0.04%
==========================================
Files 1 1
Lines 524 531 +7
==========================================
+ Hits 506 513 +7
Misses 18 18
☔ View full report in Codecov by Sentry. |
|
Thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#115 and #113 happened nearly at the same time, so the
offsetkeyword wasn't implemented forProgressUnknownthis is a ctrl+c ctrl+v of what happens for the other so hopefully it works correctly
cancel(p::ProgressUnknown)also didn't work because of that (I added testcases for cancel on all 3 types)