Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a hang in uinvalidated #336

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Fix a hang in uinvalidated #336

merged 1 commit into from
Jan 10, 2023

Conversation

timholy
Copy link
Owner

@timholy timholy commented Jan 10, 2023

Picked up as the source of hanging in the doctests. Also updates doctests to reduce the number of errors.

Picked up as the source of hanging in the doctests.
Also updates doctests to reduce the number of errors.
@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Base: 82.26% // Head: 83.63% // Increases project coverage by +1.37% 🎉

Coverage data is based on head (8a131a1) compared to base (fa775b3).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #336      +/-   ##
==========================================
+ Coverage   82.26%   83.63%   +1.37%     
==========================================
  Files          17       17              
  Lines        2176     2188      +12     
==========================================
+ Hits         1790     1830      +40     
+ Misses        386      358      -28     
Impacted Files Coverage Δ
src/parcel_snoopc.jl 78.15% <ø> (+5.04%) ⬆️
src/parcel_snoopi_deep.jl 90.01% <ø> (+0.53%) ⬆️
src/invalidations.jl 74.06% <100.00%> (+1.68%) ⬆️
src/deep_demos.jl 58.97% <0.00%> (-3.19%) ⬇️
src/parcel_snoopi.jl 95.00% <0.00%> (+3.33%) ⬆️
SnoopPrecompile/src/SnoopPrecompile.jl 94.11% <0.00%> (+3.49%) ⬆️
SnoopCompileCore/src/snoopi.jl 55.73% <0.00%> (+8.46%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@timholy timholy merged commit f3ffc99 into master Jan 10, 2023
@timholy timholy deleted the teh/hang branch January 10, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant