New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tmpdir from search path for test #2

Merged
merged 2 commits into from Jan 26, 2015

Conversation

Projects
None yet
2 participants
@perlpilot
Contributor

perlpilot commented Jan 20, 2015

Fixes RT#85529. A file called /tmp/t could cause a test failure, so we
don't look in /tmp any more (or whatever platform-specific tmpdir)

I'm not sure why tmpdir was included in addition to curdir.

Remove tmpdir from search path for test
Fixes RT#85529. A file called /tmp/t could cause a test failure, so we
don't look in /tmp any more (or whatever platform-specific tmpdir)
@timj

This comment has been minimized.

Show comment
Hide comment
@timj

timj Jan 20, 2015

I think the only reason tmpdir is in there was to provide some options. It was first in the list to ensure that it matched the second entry, then got reversed such that the first directory always matched anyhow. I suppose this patch is okay given that it no longer relies on the state of directories not under the control of the person running the tests but maybe we could add File::Spec->catdir(File::Spec->curdir, "blib") to the front of MYPATH so that we can search for a "t" directory in two locations and search for a "t" file in two locations?

timj commented on 3c8105a Jan 20, 2015

I think the only reason tmpdir is in there was to provide some options. It was first in the list to ensure that it matched the second entry, then got reversed such that the first directory always matched anyhow. I suppose this patch is okay given that it no longer relies on the state of directories not under the control of the person running the tests but maybe we could add File::Spec->catdir(File::Spec->curdir, "blib") to the front of MYPATH so that we can search for a "t" directory in two locations and search for a "t" file in two locations?

@perlpilot

This comment has been minimized.

Show comment
Hide comment
@perlpilot

perlpilot Jan 26, 2015

Contributor

I've added blib to the search path.

Contributor

perlpilot commented Jan 26, 2015

I've added blib to the search path.

timj added a commit that referenced this pull request Jan 26, 2015

Merge pull request #2 from perlpilot/rm-tmp
Remove tmpdir from search path for test

@timj timj merged commit 92d6484 into timj:master Jan 26, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment