Validate pid before calling #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`getProcessLimits` calls `child_process.exec` with the pid. Here's the
relevant line:
cp.exec("cat /proc/" + pid + "/limits", function (err, stdout, stderr) {
A malicious argument could cause trouble. For example, passing an
argument of `'; rm -rf / #'` would run the following command:
cat /proc/; rm -rf / #/limits
This minimal change validates the pid argument before continuing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getProcessLimitscallschild_process.execwith the pid. Here's the relevant line:A malicious argument could cause trouble. For example, passing an argument of
'; rm -rf / #'would run the following command:This minimal change validates the pid argument before continuing.