Split on spaces, not all non-word characters #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! It looks like it has a merge conflict though. Can you make the test the same as the example in the readme please. Don't need to use "this is dog" in the test :) |
|
Will do. I didn't realize I was a few commits behind as well, so I'll catch my branch up to hopefully avoid any merge conflicts. |
|
I've merged these changes into #3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current behavior splits on all non-word characters, which included dots and dashes. Based on the discussion in #1, instead of adding new functionality, this PR changes the previous functionality to more closely match
String.prototype.split(), while supporting quoted strings.This PR is much more minimal than #1, but still includes an updated readme and tests.