Merge pull request #85 from AndrewSouthpaw/replace-bunyan-with-smalle…

…r-logger

Remove logging functionality and drop bunyan dependency.

package.json

@@ -20,7 +20,6 @@
     "Jonas Holtkamp <jonas.holtkamp@senacor.com>"
   ],
   "dependencies": {
-    "bunyan": "^1.8.12",
     "expect": "^24.8.0"
   },
   "devDependencies": {

src/when.js

@@ -1,24 +1,18 @@
 const assert = require('assert')
 const utils = require('expect/build/jasmineUtils')
-const logger = require('./log')('when')
 
 let registry = new Set()
 
 const getCallLine = () => (new Error()).stack.split('\n')[4]
 
 const checkArgumentMatchers = (expectCall, args) => (match, matcher, i) => {
-  logger.debug(`matcher check, match: ${match}, index: ${i}`)
-
   // Propagate failure to the end
   if (!match) {
     return false
   }
 
   const arg = args[i]
 
-  logger.debug(`   matcher: ${String(matcher)}`)
-  logger.debug(`   arg: ${String(arg)}`)
-
   const isFunctionMatcher = typeof matcher === 'function' && matcher._isFunctionMatcher
 
   // Assert the match for better messaging during a failure
@@ -72,8 +66,6 @@ class WhenMock {
       this.nextCallMockId++
 
       this.fn.mockImplementation((...args) => {
-        logger.debug('mocked impl', args)
-
         for (let i = 0; i < this.callMocks.length; i++) {
           const { matchers, mockImplementation, expectCall, once, called } = this.callMocks[i]
 

src/when.test.js

@@ -1,25 +1,12 @@
-const { stringContaining } = expect
-
 const errMsg = ({ expect, actual }) =>
   new RegExp(`Expected.*${expect}.*\\nReceived.*${actual}`)
 
 describe('When', () => {
-  let spyEquals, when, WhenMock, mockLogger, resetAllWhenMocks, verifyAllWhenMocksCalled
+  let spyEquals, when, WhenMock, resetAllWhenMocks, verifyAllWhenMocksCalled
 
   beforeEach(() => {
     spyEquals = jest.spyOn(require('expect/build/jasmineUtils'), 'equals')
 
-    mockLogger = {
-      info: jest.fn(),
-      debug: jest.fn(),
-      warn: jest.fn(),
-      error: jest.fn(),
-      fatal: jest.fn(),
-      trace: jest.fn()
-    }
-
-    jest.mock('./log', () => () => mockLogger)
-
     when = require('./when').when
     resetAllWhenMocks = require('./when').resetAllWhenMocks
     verifyAllWhenMocksCalled = require('./when').verifyAllWhenMocksCalled
@@ -428,7 +415,6 @@ describe('When', () => {
 
       expect(fn(5)).toBeUndefined()
       expect(fn(symbol, 2)).toBe('x')
-      expect(mockLogger.debug).toBeCalledWith(stringContaining('matcher: Symbol(sym)'))
     })
 
     it('returns nothing if no declared value matches', () => {
@@ -437,8 +423,6 @@ describe('When', () => {
       when(fn).calledWith(1, 2).mockReturnValue('x')
 
       expect(fn(5, 6)).toBeUndefined()
-      expect(mockLogger.debug).toBeCalledWith(stringContaining('matcher: 1'))
-      expect(mockLogger.debug).not.toBeCalledWith(stringContaining('matcher: 2'))
     })
 
     it('expectCalledWith: fails a test with error messaging if argument does not match', () => {