Refactored tdclient with session handler and exceptions #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging my fork to head repo
This is a basic stub function, I don't have tests cause I didn't TDD for these. I have additional supporting libraries that add the rest of the functionality to complete an order, but they depend on the QuickType library that I've developed. It's too much for one commit to add all that to this library. I need to figure out a way to integrate them into this library, and I will attempt to add them as soon as I have time.
TDAmeritrade has some sample JSON data in their guides section that shows valid schema. https://developer.tdameritrade.com/content/place-order-samples Added the JSON string to its own file and imported as a fixture to be used by test_orders and test_saved_orders
I use a design pattern described by Ben Homnick (http://bhomnick.net/design-pattern-python-api-client/) to separate the transport request from the application logic. The TDClient now uses a TDASession class, which inherits from requests. It doesn't do much right now, but my plan is to move the authentication functionality to it at some point. The client _request function passes all the various methods to the session, and will throw exceptions if the response is anything other than a 200, or 201 as happens when placing orders. This check will probably get moved into session so that it can try refreshing the token when 401s are thrown. I added tests for as much as I could; I'm starting to get a better handle on mock, so I think this is moving in the right direction.
# Conflicts: # tdameritrade/client.py
|
Not sure why the fails, I assume it's something with the new CI, cause i doesn't look like the tests were actually executed. I originally ran 3.6.9 on my environment but just pulled 3.7 and everything passed as well. |
|
did you run lint? |
Restored the 'return resp' pattern for consistency. Newline and continuation indentation issues corrected.
timkpaine
approved these changes
Mar 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty big design change, I put a lot of work into it.